Fix the usage of supportsPrincipals when I really wanted supportsCTags

I think I've found it. From the Google Contacts API, we find that the Home Set (/lists) contains all the other address books (/lists/default being one of them, but there can be more), but no contacts, so from my understanding, this is why the Home Set does not have any CTag. For some reason, it is also not possible to get the CTag of child collections from the /lists URL. I think the best solution is to refresh every collections individually in KDAV2 in the DavCollectionsFetchJob.

No, we do have the Content-Type: text/xml; charset=utf-8 in KDav2 (Google apparently don't care if it's text/xml or application/xml, and from the XML RFC, the only difference between the two is human readability). The issue was more in the way I was testing from the command-line. The issue with Sink seems to be that Google can't find the getctag property (whereas it works from the command-line). This is weird since the propfind.xml is basically a copy paste from Sink's logs.

Well, it seems that Google is completely ignoring the request if the Content-Type: application/xml is not present so adding -H "Content-Type: application/xml" to Curl's command line does the trick, and Google returns a valid CTag

Revert and rename only in the UI

Renamed the "GMail" account to "Google". It seems that those who already have a Google account can remove their account from the command-line only, and then add it again from Kube

• Fix model notifications by fixing the contains function
• Add tests to the contains and exists functions from the Entity store

Fix the testModifyWithConflict from pipelinetest by fixing the readRevisions function which was still using UIDs to access a main database. Now it uses the uidsToRevisions database.

• Fixed the random reading issues on database with integer keys with great help from Christian
• Fixed the readPrevious function from the entity store
• Fixed dumb issue in the size_t variant of the scan function
• Add some storage tests

Put syntax and REGISTER_SYNTAX at the bottom

Better explanation of the --reduce option in the list command

Wrap assignment in lambda

Make assignation clear.

The benchmark tables are now updated, for some reason, memory went up in "Run benchmarks", but down in "Test Disk Usage"

• Since Keys and Identifiers can now be "null", we can convert the selection part of the Reduce filter to use Identifiers
• Also added the operator== and operator!= to Identifier, Revision and Key
• Benchmark update coming up

Remove invalid comments about avoiding default construction

• Default constructor of Identifier now produces null ids
• Remove deprecation of Key's default constructor
• Safety net: assert the uid is not null when converting to binary representation (when we pass it to the database)

Fix empty function

I'd say so too! But I'm still not sure why the disk statistics are so underwhelming :-/

Results of the Dummy resource write benchmark:

Some disk statistics:

Increment database version

• Use QUuid constructor instead of fromString
• Remove useless comments

• Fix pipeline test
• Fix some issues with changereplay

Here are the result of a quick run of benchmarks (mailquerytest and pipelinetest) but I fear that there might not be enough samples for these to be statistically sound

I will probably move the Key / Identifier / Revision classes into entitystore since these are entity keys, etc.

They are used to partition the events into the right day of the week (like before)

• Test live queries
• Remove dates from the index (worst general case, but we're generally not the general case)

Wait before merging it, storing the dates alongside the reference in the index is a "bad optimization" (changed my mind over the WE):

Nitpicks

Remove the ahead-of-time finding of the closest key to the upper bound

Correct! This is no longer the case

Register color in Kube.Colors
Follow attribute naming conventions

Rebase and remove useless testSyncCal

The testSyncCal's original purpose was:

Document test requirements

Oh right, I still haven't figured out how to configure Cyrus for CalDAV or how to add test data. My solution was to install a Radicale server, and add a MyCalendar with one event in it. I should have documented this in the test file, but I forgot. I'll fix that

• Remove useless comment
• Return empty ID on event removal

Separate value extraction and processing

Fix nitpicks

• Add period filtering (with start and length properties)
• Rename EventTreeModel to PeriodDayEventModel (because it does the partitioning + filter according to a period)

Removed some assertions and dynamic_cast a pointer instead of a reference

• Fix copyright
• Switch to live query
• React to layoutChanged, rowsInserted / Moved / Removed, and modelReset signals from sink's model
• Remove debug manual synchronization of sink store
• Notify views with the modelReset signal
• Get data from the store instead of test data

• Update to the adding of the Event preprocessor in Sink (T8485)
• Set the resources correctly in the calendar view

Fixed the license header to display 2018 instead 2017
Add an assertion to check that the given iCal is valid in the Event property extractor