Differential D14404

Use Key API in SinkSH
ClosedPublic
Actions

Authored by rnicole on Jul 26 2018, 3:02 PM.

Details

Reviewers
cmollekopf
Commits
R9:6fcb97ad464a: Use Key API in SinkSH
Summary

Depends on D14289

  • Fixes the sinksh inspect … command
  • Introduces isValid, isValidInternal and isValidDisplay static functions in Key, Identifier and Revision

I still have to do a more extensive search for induced bugs in other commands

Diff Detail

Repository
R9 Sink
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
rnicole requested review of this revision.Jul 26 2018, 3:02 PM
rnicole created this revision.
rnicole edited the summary of this revision. (Show Details)
cmollekopf accepted this revision.Jul 27 2018, 9:15 AM
This revision is now accepted and ready to land.Jul 27 2018, 9:15 AM
Closed by commit R9:6fcb97ad464a: Use Key API in SinkSH (authored by rnicole, committed by cmollekopf). · Explain WhyJul 27 2018, 2:15 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 38610

View Options

common/storage/key.h

Loading...
View Options

common/storage/key.cpp

Loading...
View Options

sinksh/syntax_modules/sink_inspect.cpp

Loading...