Fix some warnings

Authored by rnicole on Aug 24 2018, 2:04 PM.



On GCC, my effective CATCH_ERRORS config is:

add_definitions("-Werror -Wall -Wextra -Wno-unknown-pragmas -Wno-unused-function -Wno-cast-align -Wno-shadow -Wno-deprecated -Wno-old-style-cast -Wno-unused-parameter -Wno-padded -Wno-missing-noreturn -Wno-sign-conversion -Wno-vla -Wno-zero-as-null-pointer-constant -Wno-switch-enum -Wno-unused-result -Wno-unused-value")
  • -Wno-unused-result because of the calls to the external program and such
  • -Wno-unused-value because apparently the call to the VERIFYEXEC_RET macro in imapmailsynctest.cpp in the createMessage function has a statement that does nothing

Diff Detail

R9 Sink
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
rnicole requested review of this revision.Aug 24 2018, 2:04 PM
rnicole created this revision.
This revision was not accepted when it landed; it landed in state Needs Review.Aug 26 2018, 3:36 PM
Closed by commit R9:00f7a539789e: Fix some warnings (authored by rnicole, committed by cmollekopf). · Explain Why
This revision was automatically updated to reflect the committed changes.