with aar, it will contain an AndroidManifest.xml which contain required permission already + java source code, and we don't need to modify AndroidManifest.xml in krita project any more.

Okay, we can consider the release as done! Yay! :)

We still have two checkpoints to be done/verified:

We cannot have a precompiled class in our package. The class should be built as part of the build process for the sonarpen-sdk-cpp:

Okay, the current issues with the implementation:

Okay, we should first switch to API 34, not to 35

The port is now complete by @freyalupen! :)

One more related issue:

I'm afraid I cannot resolve this Gradle issue in a polynominal time, since I have no idea about Gradle. Perhaps someone could look into that? I have prepared the prebuilt deps for Krita, so it should be a little bit easier to to use continue the work

Okay, it looks like the release is done! Thanks to everyone! :)

Here is the .aab package with the updated version with your patch: https://invent.kde.org/graphics/krita/-/jobs/2162818/artifacts/raw/_packaging/krita-5.2.6-release.aab

MR for the release announcement: https://invent.kde.org/websites/krita-org/-/merge_requests/69

It seems like we have a critical regression in 5.2.5 :( Can we rollback the current release from the Stores and start preparing the new one?

What we left now:

Okay, @vanyossi reported that there is some flake issue in the release packages for MacOS:

Related task about IWYU: https://phabricator.kde.org/T17610

Here is the patch I tried (generated with IWYU): https://invent.kde.org/dkazakov/krita/-/commit/c14fd2d1948105f192819a6db708a9e6dd1af751
Full branch: https://invent.kde.org/dkazakov/krita/-/commits/kazakov/iwyu-try-for-kritaimage?ref_type=heads

I've started KA discussion about the related topic raised in bug 461553

Related bugs:

Additional note: it seems like the way how the out-of-bounds source of the clone layers is regenerated should be redesigned. Right now, it is done in KisUpdateOriginalVisitor in an ad-hoc manner. It means that if the source layer has any kind of mask that extends the accessRect, then the image will experience unsafe multithreaded access with multiple threads writing into the same pixel.

It seems like we still have a few issues with this release:

The angular brackets thing for includes outside has actually been our coding standard since the kimageshop days, but lots of people are pretty sloppy -- and then also, files get moved from library to library.

Okay, here is the proposal based on the KDE CI scripts:

Okay, the Windows CI is now fully deployed. There is only one todo item that should be fixed before we move release builds to Gitlab:

A note from bcooksley: I would suggest we use something like teams/krita/ [namespace] for hosting those [forked dependencies]

A text shape can flow into multiple shapes, within SVG these are just linked, so both grouped and ungrouped is possible within SVG.

Btw, a new set of weird technical questions:

Right now, for text path we are required to only apply 'local transforms' on the textpath

Can this include changing the text orientation from inside the path to outside the path (for example text outside the circle and text inside the circle path)

Just a note: we need some better way to manage git repositories for the deps. The thing that happened today was that @lsegovia removed a branch in their personal repo (I guess it was renamed, though I'm not sure), and it broke our deps builds.

first update the deps, verify Krita still builds with it, and then have an MR for Krita. I'm not sure why, but I think it would give me a bit of a safe feeling...

Just a note:

There are two different sets of expiry times we're referring to here i'm afraid

Thank you for your replies!

Weston's ICC -> GPU implementation:

Oh, another manual needed:

So, what you're saying is that having deps commits mixed in with Krita commits helps somehow to figure out which dep change was related to which change in Krita <...> I don't think that's important at all.

Well, no. It won't be materially different because right now the deps build and the krita build are completely separate already. They might be in the same repo, but the build systems do not connect.

Problems of the split repos:

Krita's unstable branch would always checkout the master branch of the deps repo

Maybe related, maybe not, but I thought today that maybe we should spin our deps build system into a separate repo with stable and unstable branches, and actual releases.

Notes on the KDE's CI system

After yesterday's discussion on IRC I have added one more requirement to the system:

Hi, @alvinhochun and @vanyossi!

The ASWF dependency management system for the VFX platform images relies on compositing Docker images

I have seen this warning when writing the lager code. I even tried to switch to the lambda syntax, but the resulting code looks a bit too verbose. Specifically, you need to explicitly declare all the typenames for every function argument (which might not known in the template context).

So, conceptually, we divide that GlobalRect into smaller contiguous, non-overlaping, regions or tiles

What is the difference between having a group with one child and having a layer with a mask? In both cases it's two entries, one below the other. Both can be compressed to just one entry, too.

the shape for background and for the border is the same, but the border one has only stroke and the background one has only a fill

Note about workflow of the knife tool: