chrisx (Chris Xiong)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
May 11 2018, 8:39 AM (312 w, 1 d)
Availability
Available

Recent Activity

Sep 10 2019

chrisx updated the diff for D12827: Added process details in the process list context menu.

@meven Sorry I've totally forgotten about your suggestions when I was updating the patch...
I have renamed DetailsDlg to ProcessDetailsDialog. But I've got some minor issues with code indentation. I have tried out uncrustify-kf5 (which didn't even work out-of-box. Instead of formatting the files in-place, it produced *.uncrustify files instead. I have uncrustify 0.69, and I worked around the issue by adding --replace to the arguments for uncrystify in uncrustify-kf5). But the script produces way too many changes in some files I changed. One of those files is processes_linux_p.cpp, which uses both spaces and tabs for indentation. So at this moment I've only committed some of the indentation changes.
Any further help with pushing this patch forward would be greatly appreciated.

Sep 10 2019, 3:14 PM · Plasma

Sep 8 2019

chrisx added a comment to D12827: Added process details in the process list context menu.

Patch updated. Any suggestions?

Sep 8 2019, 2:40 AM · Plasma
chrisx updated the diff for D12827: Added process details in the process list context menu.

Rebased to master. Removed uses of deprecated class (QRegExp). Tidied the code up a bit.

Sep 8 2019, 2:40 AM · Plasma

Aug 17 2019

chrisx added a comment to D12827: Added process details in the process list context menu.

I quite like this feature @chrisx
I hope you can still push it forward after all this time.

Aug 17 2019, 5:54 AM · Plasma

Sep 14 2018

chrisx added a comment to D12827: Added process details in the process list context menu.

Any updates on whether this patch could be merged? It has been a long wait. If there are any improvements I can make to the patch I will be more than happy to put more work into it.

Sep 14 2018, 11:45 AM · Plasma

Jun 13 2018

chrisx added reviewers for D12827: Added process details in the process list context menu: broulik, davidedmundson.
Jun 13 2018, 12:42 AM · Plasma

Jun 9 2018

chrisx updated the diff for D12827: Added process details in the process list context menu.

Added detailed memory information to the new process details dialog. Like the original implementation, it displays a message if some of the items are not available.

Jun 9 2018, 3:08 PM · Plasma

Jun 7 2018

chrisx added a comment to D12827: Added process details in the process list context menu.

The existing "Show detailed memory information" and "Process details". I think they can be merged.

The show detailed memory information is a QtWebKit-powered "plugin" (I would love to get rid of tbh)

Jun 7 2018, 1:53 PM · Plasma

May 11 2018

chrisx requested review of D12827: Added process details in the process list context menu.
May 11 2018, 2:49 PM · Plasma