chrisrowland (Chris Rowland)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Apr 19 2020, 9:56 AM (10 w, 5 d)
Availability
Available

Recent Activity

May 31 2020

chrisrowland added a comment to D29836: Code refactoring unifying capture initialization for new sequences and continuing of sequences.

I'm sorry but I don't think I am qualified to review a refactor of the
capture module because I do not have enough understanding of the capture
process to be able to contribute.

May 31 2020, 9:53 PM · KDE Edu

May 10 2020

chrisrowland added a comment to D29549: Updates to SkyPoint to improve positions.

I've fixed the test problem, I wasn't calculating the expected error in Ra correctly at high declinations.

May 10 2020, 7:32 AM · KDE Edu
chrisrowland updated the diff for D29549: Updates to SkyPoint to improve positions.

Fix problem with test failures at high declinations

May 10 2020, 7:30 AM · KDE Edu

May 9 2020

chrisrowland added a reviewer for D29549: Updates to SkyPoint to improve positions: mutlaqja.
May 9 2020, 9:02 AM · KDE Edu
chrisrowland requested review of D29549: Updates to SkyPoint to improve positions.
May 9 2020, 8:59 AM · KDE Edu

May 6 2020

chrisrowland added a comment to D29471: Save HA Limit Enable checkbox.

Fine, I never did get to the bttom of how the Options worked.

May 6 2020, 3:34 PM · KDE Edu

May 4 2020

chrisrowland added a comment to D29355: Fix issue with Meridian Flip Retry.

No reason to delay.

May 4 2020, 9:58 AM · KDE Edu
chrisrowland added a comment to D29355: Fix issue with Meridian Flip Retry.

The general comments are a great help in understanding what this does but don't address what I think is needed, more description in the code of what is being done and why. The comments here are ephemeral and in six months time when somebody else needs to work on this code they will not be available.

May 4 2020, 9:54 AM · KDE Edu

May 2 2020

chrisrowland added inline comments to D29355: Fix issue with Meridian Flip Retry.
May 2 2020, 3:21 PM · KDE Edu
chrisrowland added a comment to D29355: Fix issue with Meridian Flip Retry.

I can't comment on the change to the way that the capture meridian flip state and the mount meridian flip status state machines interact because there's no description of how the capture state machine works, nor what these changes do and why.

May 2 2020, 11:11 AM · KDE Edu

Apr 24 2020

chrisrowland updated the diff for D29008: Use the mount Pier Side property to manage Pier Flip.

Further changes as requested

Apr 24 2020, 11:42 AM · KDE Edu
chrisrowland updated subscribers of D29008: Use the mount Pier Side property to manage Pier Flip.

Thanks everyone for this.

Apr 24 2020, 7:07 AM · KDE Edu

Apr 23 2020

chrisrowland added a comment to D29008: Use the mount Pier Side property to manage Pier Flip.

I've submitted a diff with most of the changes requested incorporated.

Apr 23 2020, 10:18 PM · KDE Edu
chrisrowland updated the diff for D29008: Use the mount Pier Side property to manage Pier Flip.

Fixes as requested

Apr 23 2020, 5:57 PM · KDE Edu
chrisrowland added a comment to D29008: Use the mount Pier Side property to manage Pier Flip.

My first attempt to add inline comments failed, try again.

Apr 23 2020, 11:40 AM · KDE Edu
chrisrowland added a comment to D29008: Use the mount Pier Side property to manage Pier Flip.

Thanks for the feedback,
I've skimmed through this and put in some comments, primarily about the QString issue that TFM raised.

Apr 23 2020, 10:59 AM · KDE Edu

Apr 20 2020

chrisrowland added a reviewer for D29008: Use the mount Pier Side property to manage Pier Flip: mutlaqja.
Apr 20 2020, 5:49 PM · KDE Edu
chrisrowland requested review of D29008: Use the mount Pier Side property to manage Pier Flip.
Apr 20 2020, 11:05 AM · KDE Edu