I'm sorry but I don't think I am qualified to review a refactor of the
capture module because I do not have enough understanding of the capture
process to be able to contribute.

I've fixed the test problem, I wasn't calculating the expected error in Ra correctly at high declinations.

Fix problem with test failures at high declinations

Fine, I never did get to the bttom of how the Options worked.

No reason to delay.

The general comments are a great help in understanding what this does but don't address what I think is needed, more description in the code of what is being done and why. The comments here are ephemeral and in six months time when somebody else needs to work on this code they will not be available.

I can't comment on the change to the way that the capture meridian flip state and the mount meridian flip status state machines interact because there's no description of how the capture state machine works, nor what these changes do and why.

Further changes as requested

Thanks everyone for this.

I've submitted a diff with most of the changes requested incorporated.

Fixes as requested

My first attempt to add inline comments failed, try again.

Thanks for the feedback,
I've skimmed through this and put in some comments, primarily about the QString issue that TFM raised.