Thank you for committing! Although I recently gained push rights, I did not have time yet to dig into the details of how to create/push commit respecting the KDE standards etc. Next time, I'll try on my own :)
- Queries
- All Stories
- Search
- Advanced Search
Advanced Search
May 26 2020
Apr 22 2020
The initial diff was incomplete. This one covers all occurrences of Q_EMIT.
Apr 21 2020
OK, then please commit the changes as Tobias Junghans <tobias.junghans@veyon.io> - thanks in advance :-)
I just applied for a developer account. Once approved and got access to the kldap repository, I'll commit the changes. If things do not work this way, you can commit the changes too.
Thanks for reviewing! Is there any timeline when the changes will be visible in the Git repository?
Apr 20 2020
Apr 18 2020
Yes, I tested against Samba 4.7 with both SSL (LDAPS/port 636) and TLS. The CA certificate has been supplied via LdapServer::setTLSCACertFile(...) and verification enforced via LdapServer::setTLSRequireCertificate(LdapServer::TLSReqCertHard). Without this patch, only TLS works even when setting LdapServer::TLSReqCertNever since this option is ignored in the previous implementation for the SSL case. With this patch applied, SSL/LDAPS works fine too.
Apr 17 2020
Mar 20 2018
Improved user-visible error strings