When I was updating this client's UI, I was pretty conflicted about using group boxes, many of the other VPN clients were using group boxes for their main window and at one stage I was thinking of introducing group boxes for the main window of this client. It was definitely this client's PPP settings dialog which uses multiple group boxes that initially convinced me to use group boxes with the IPsec settings dialog.
- Queries
- All Stories
- Search
- Advanced Search
Feed Advanced Search
Advanced Search
Advanced Search
Mar 4 2020
Mar 4 2020
updates based on review comments
I'm of mixed minds on the group boxes.
Mar 3 2020
Mar 3 2020
In D27764#621173, @jgrulich wrote:@dkosovic will you update the review to address my comments?
Mar 1 2020
Mar 1 2020
This patch depends on D27763 being applied first.
Jun 9 2017
Jun 9 2017
I'm not aware of being given any privileges to push it. If I was to push it, I'm guessing I need to use Arcanist and git?
Jun 6 2017
Jun 6 2017