UI updates for NetworkManager-l2tp 1.2.6

Authored by dkosovic on Jun 6 2017, 10:28 AM.



Could the plasma-nm/vpn/l2tp/ source be updated to support IPsec changes introduced with NetworkManager-l2tp version 1.2.6.

A screen shot of the current GNOME IPsec UI can be viewed here:

A summary of the changes for NetworkManager-l2tp 1.2.6 include:

Added the following to IPsec UI:

  • Phase 1 algorithms
  • Phase 2 algorithms
  • Enforce UDP encapsulation

Removed the following from IPsec UI:

  • Group Name

Copied nm-l2tp-service.h from NetworkManager-l2tp 1.2.6

Phase 1 & 2 algorithms UI additions are compatible with NetworkManager-l2tp versions 1.2.6 and 1.0.6 (from the 1.0.x series which has the changes backported from 1.2.6)

Diff Detail

R116 Plasma Network Management Applet
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
dkosovic created this revision.Jun 6 2017, 10:28 AM
Restricted Application added a subscriber: plasma-devel. · View Herald TranscriptJun 6 2017, 10:28 AM
jgrulich accepted this revision.Jun 6 2017, 1:53 PM

Looks good to me. I tested it a bit, all properties were saved and loaded properly.

This revision is now accepted and ready to land.Jun 6 2017, 1:53 PM

Do you have access to push this? Or do you want me to do it instead?

I'm not aware of being given any privileges to push it. If I was to push it, I'm guessing I need to use Arcanist and git?

But I'm happy for you to push it.

This revision was automatically updated to reflect the committed changes.