What is missing:
- Declaration with alias into grouped namespace are not processed: use Foo\ { const C as FooC };
- There is no test
- The mix between UseImportType, ParserUseImportType, DeclarationType is not clean
What is missing:
The test output:
2: FAIL! : Php::TestDUChain::classMemberVar() 'var->type<IntegralType>()' returned FALSE. () 2: Loc: [/home/hmitonneau/kde/src/kdev-php/duchain/tests/duchain.cpp(449)]
In D29444#663891, @zhigalin wrote:Are the trailing commas from T6804 supported?
I have compiled from scratch with kdesrc-build (with cmake-options -DCMAKE_BUILD_TYPE=RelWithDebInfo). The duchain test still doesn't pass.
After some debug, it seems that m_gotTypeFromTypeHint is not always initialized correctly.
The following patch fix the problem for me:
Sorry for the very late comment...
Before this commit, the type of properties were deduced from the assign default value:
add some tests
fix: const are case sensitive
improve tests
No problem.
You can use hugues@mitonneau.me
Thanks
This new patch re-implement KDevelop::BasicRefactoring::applyChangesToDeclarations and KDevelop::BasicRefactoring::applyChanges in Php::Refactoring.
No, I don't have commit access.
Is there something wrong with the second diff ?