In D5183#114278, @kfunk wrote:@coopht Planning to address apol's concerns?
- Queries
- All Stories
- Search
- Advanced Search
Feed Advanced Search
Advanced Search
Advanced Search
Jun 5 2017
Jun 5 2017
Apr 11 2017
Apr 11 2017
In D5183#100686, @aspotashev wrote:Hi Alexander,
When I accidentally close a file, I use the existing action "Previous Visited Context". What you are implementing is only useful after accidentally closing several files. Is that what you want?
Apr 7 2017
Apr 7 2017
In D5183#98731, @apol wrote:In D5183#98625, @coopht wrote:In D5183#98623, @apol wrote:Wouldn't it make sense to implement it somewhere separate as an observer rather than making the current sublime/container class even bigger?
I don't think that these changes making sublime/container much bigger. This is a pretty small changes and the idea is to track closed files for each container.
What is the proper place to implement it as an observer?You could add a ReopenAction class. Either in Sublime or the shell.
Move reopenClosedTab functionality to ReopenAction class.
Mar 29 2017
Mar 29 2017
In D5183#98623, @apol wrote:Wouldn't it make sense to implement it somewhere separate as an observer rather than making the current sublime/container class even bigger?
I don't think that these changes making sublime/container much bigger. This is a pretty small changes and the idea is to track closed files for each container.
What is the proper place to implement it as an observer?
Mar 28 2017
Mar 28 2017
Use stack to track closed files.
Use proper events to handle file closing.
What is the purpose of a default argument value only in the definition? Especially when installed headers will miss that info bit about the default argument value?I have never seen this before.
It's a mistake. I fixed it.
But the code was accepted by gcc-4.6.3
The hotkey is also application wide, no? So how is this supposed to work in a split view configuration? I assumed it would simply restore the file in the corresponding container?
Yes, It will restore files in corresponding container from container's queue.
Mar 26 2017
Mar 26 2017
Update.
Take into account 'Close other tabs' action.