Feed Advanced Search

Jun 5 2017

coopht added a comment to D5183: Reopen accidentally closed tab.
In D5183#114278, @kfunk wrote:

@coopht Planning to address apol's concerns?

Jun 5 2017, 1:22 PM

Apr 11 2017

coopht added a comment to D5183: Reopen accidentally closed tab.

Hi Alexander,

When I accidentally close a file, I use the existing action "Previous Visited Context". What you are implementing is only useful after accidentally closing several files. Is that what you want?

Apr 11 2017, 2:42 PM

Apr 7 2017

coopht added a comment to D5183: Reopen accidentally closed tab.
In D5183#98731, @apol wrote:
In D5183#98625, @coopht wrote:
In D5183#98623, @apol wrote:

Wouldn't it make sense to implement it somewhere separate as an observer rather than making the current sublime/container class even bigger?

I don't think that these changes making sublime/container much bigger. This is a pretty small changes and the idea is to track closed files for each container.
What is the proper place to implement it as an observer?

You could add a ReopenAction class. Either in Sublime or the shell.

Apr 7 2017, 5:41 AM
coopht updated the diff for D5183: Reopen accidentally closed tab.

Move reopenClosedTab functionality to ReopenAction class.

Apr 7 2017, 5:32 AM

Mar 29 2017

coopht added a comment to D5183: Reopen accidentally closed tab.
In D5183#98623, @apol wrote:

Wouldn't it make sense to implement it somewhere separate as an observer rather than making the current sublime/container class even bigger?

I don't think that these changes making sublime/container much bigger. This is a pretty small changes and the idea is to track closed files for each container.
What is the proper place to implement it as an observer?

Mar 29 2017, 3:35 AM

Mar 28 2017

coopht updated the diff for D5183: Reopen accidentally closed tab.

Use stack to track closed files.
Use proper events to handle file closing.

Mar 28 2017, 8:46 PM
coopht added a comment to D5183: Reopen accidentally closed tab.
What is the purpose of a default argument value only in the definition? Especially when installed headers will miss that info bit about the default argument value?

I have never seen this before.

It's a mistake. I fixed it.
But the code was accepted by gcc-4.6.3

Mar 28 2017, 1:37 AM
coopht added a comment to D5183: Reopen accidentally closed tab.

The hotkey is also application wide, no? So how is this supposed to work in a split view configuration? I assumed it would simply restore the file in the corresponding container?

Yes, It will restore files in corresponding container from container's queue.

Mar 28 2017, 1:35 AM

Mar 26 2017

coopht updated the diff for D5183: Reopen accidentally closed tab.

Fix style.

Mar 26 2017, 10:48 PM
coopht added inline comments to D5183: Reopen accidentally closed tab.
Mar 26 2017, 10:43 PM
coopht updated the diff for D5183: Reopen accidentally closed tab.

Update.
Take into account 'Close other tabs' action.

Mar 26 2017, 9:07 PM
coopht added inline comments to D5183: Reopen accidentally closed tab.
Mar 26 2017, 7:34 PM
coopht created D5183: Reopen accidentally closed tab.
Mar 26 2017, 2:52 PM