In D14988#320052, @hein wrote:And @phuongn, I'm guessing you set all of these options to disabling wrap-around, right?
- Queries
- All Stories
- Search
- Advanced Search
Feed Advanced Search
Advanced Search
Advanced Search
Sep 4 2018
Sep 4 2018
phuongn added a comment to D14988: Implement option to toggle page navigation wraps around for pager plasmoid.
Aug 31 2018
Aug 31 2018
phuongn updated the diff for D14989: Implement option to toggle desktop navigation wraps around for desktop switching using mouse action.
Agree! Updated 馃檪
phuongn updated the diff for D14989: Implement option to toggle desktop navigation wraps around for desktop switching using mouse action.
Ok! I updated the string, it's now "Enable desktop navigation wraps around"
Aug 29 2018
Aug 29 2018
phuongn updated the diff for D14989: Implement option to toggle desktop navigation wraps around for desktop switching using mouse action.
Correct the erroneous logic for determining the next and previous desktop index
phuongn updated the diff for D14988: Implement option to toggle page navigation wraps around for pager plasmoid.
Good spot! I was too careless there. The erroneous logic for determining the next and previous desktop index is now corrected.
Aug 28 2018
Aug 28 2018
phuongn added a comment to D14988: Implement option to toggle page navigation wraps around for pager plasmoid.
Currently there is already "Desktop navigation wraps around" option for Virtual Desktops, which serve exact same purpose as this patch, but only for keyboard shortcut.
I used "Page navigation wraps around" because the pager can be used to control either Desktop or Activity, so I used "Page" instead of "Desktop" and keep the rest of the string similar to existing option from Virtual Desktops settings. Using other strings might confuse user of what this does.
phuongn added a comment to D14988: Implement option to toggle page navigation wraps around for pager plasmoid.
Hi, it's just the default desktop changing effect. Activated by scrolling with the cursor hovering on the pager. I haven't changed the effect, just added an option to toggle page wrapping
phuongn updated the diff for D14989: Implement option to toggle desktop navigation wraps around for desktop switching using mouse action.
Use standard min max functions to make code more readable for desktopswitch no-wrap option
phuongn updated the diff for D14988: Implement option to toggle page navigation wraps around for pager plasmoid.
Utilize Math methods (min, max) to make the code more readable
phuongn added inline comments to D14988: Implement option to toggle page navigation wraps around for pager plasmoid.
Aug 22 2018
Aug 22 2018
phuongn added a comment to D14988: Implement option to toggle page navigation wraps around for pager plasmoid.
I couldn't find an easy way to access KWindowSystem config from there.
On the other hand, I personally prefer wrapping when using keyboard shortcut and no wrapping when using mouse or touchpad gesture. I figured some people might need the same flexibility.
phuongn added a reviewer for D14988: Implement option to toggle page navigation wraps around for pager plasmoid: Plasma.