phuongn (Phuong Nguyen)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Aug 22 2018, 7:26 AM (298 w, 2 d)
Availability
Available

Recent Activity

Sep 4 2018

phuongn added a comment to D14988: Implement option to toggle page navigation wraps around for pager plasmoid.
In D14988#320052, @hein wrote:

And @phuongn, I'm guessing you set all of these options to disabling wrap-around, right?

Sep 4 2018, 11:02 AM · Plasma

Aug 31 2018

phuongn updated the diff for D14989: Implement option to toggle desktop navigation wraps around for desktop switching using mouse action.

Agree! Updated 🙂

Aug 31 2018, 9:06 PM · Plasma
phuongn updated the diff for D14989: Implement option to toggle desktop navigation wraps around for desktop switching using mouse action.

Ok! I updated the string, it's now "Enable desktop navigation wraps around"

Aug 31 2018, 8:52 PM · Plasma

Aug 29 2018

phuongn updated the diff for D14989: Implement option to toggle desktop navigation wraps around for desktop switching using mouse action.

Correct the erroneous logic for determining the next and previous desktop index

Aug 29 2018, 6:43 AM · Plasma
phuongn updated the diff for D14988: Implement option to toggle page navigation wraps around for pager plasmoid.

Good spot! I was too careless there. The erroneous logic for determining the next and previous desktop index is now corrected.

Aug 29 2018, 6:39 AM · Plasma

Aug 28 2018

phuongn added a comment to D14988: Implement option to toggle page navigation wraps around for pager plasmoid.

Currently there is already "Desktop navigation wraps around" option for Virtual Desktops, which serve exact same purpose as this patch, but only for keyboard shortcut.
I used "Page navigation wraps around" because the pager can be used to control either Desktop or Activity, so I used "Page" instead of "Desktop" and keep the rest of the string similar to existing option from Virtual Desktops settings. Using other strings might confuse user of what this does.

Aug 28 2018, 3:05 PM · Plasma
phuongn added a comment to D14988: Implement option to toggle page navigation wraps around for pager plasmoid.

Hi, it's just the default desktop changing effect. Activated by scrolling with the cursor hovering on the pager. I haven't changed the effect, just added an option to toggle page wrapping

Aug 28 2018, 2:49 PM · Plasma
phuongn updated the diff for D14989: Implement option to toggle desktop navigation wraps around for desktop switching using mouse action.

Use standard min max functions to make code more readable for desktopswitch no-wrap option

Aug 28 2018, 1:58 PM · Plasma
phuongn updated the diff for D14988: Implement option to toggle page navigation wraps around for pager plasmoid.

Utilize Math methods (min, max) to make the code more readable

Aug 28 2018, 11:44 AM · Plasma
phuongn added inline comments to D14988: Implement option to toggle page navigation wraps around for pager plasmoid.
Aug 28 2018, 11:35 AM · Plasma

Aug 22 2018

phuongn added a comment to D14988: Implement option to toggle page navigation wraps around for pager plasmoid.

I couldn't find an easy way to access KWindowSystem config from there.
On the other hand, I personally prefer wrapping when using keyboard shortcut and no wrapping when using mouse or touchpad gesture. I figured some people might need the same flexibility.

Aug 22 2018, 8:18 AM · Plasma
phuongn requested review of D14989: Implement option to toggle desktop navigation wraps around for desktop switching using mouse action.
Aug 22 2018, 8:12 AM · Plasma
phuongn added a reviewer for D14988: Implement option to toggle page navigation wraps around for pager plasmoid: Plasma.
Aug 22 2018, 8:03 AM · Plasma
phuongn requested review of D14988: Implement option to toggle page navigation wraps around for pager plasmoid.
Aug 22 2018, 8:01 AM · Plasma