Feed Advanced Search

Jan 9 2020

mphilippov added a comment to D25423: Fill table cells with color for ODS and XLSX files.

Do you mean this "if ()" part of code? If there is no style "graphic" and inner "if" will not execute. Do you mean it'll be better to handle it in this part of code...or what?

The main question was how should the three attributes play together. But another question: why isn't setBackgroundColor enough for the background color?

Jan 9 2020, 8:52 AM · Calligra: 3.0

Jan 7 2020

mphilippov added a comment to D25423: Fill table cells with color for ODS and XLSX files.

loadTableCellProperties() is a method for applying styles for table cells, i.e. cell background. There is no handling for cell background in the place you mentioned.

I'm talking about handling in that particular method. It will already set background brush in that method later. Why is that not enough?

Jan 7 2020, 9:59 AM · Calligra: 3.0
mphilippov added a comment to D25423: Fill table cells with color for ODS and XLSX files.

Not sure about all the details but two things look suspicious here:

  1. Above this there's handling for transparent and now the handling isn't symmetric for background brush.
  2. There's some handling on the file for KoXmlNs::draw / style-name & KoXmlNs::calligra / fill-style-name which do background brush setting. What's the relation between these three?
Jan 7 2020, 7:19 AM · Calligra: 3.0

Dec 31 2019

mphilippov requested review of D26328: Calculate and display proper number for headings started with lower level for DOC, DOCX and ODT..
Dec 31 2019, 12:34 PM · Calligra: 3.0

Dec 2 2019

mphilippov added reviewers for D25422: Handle custom-shapes to display text in ODP files: pvuorela, dcaliste.
Dec 2 2019, 3:04 PM · Calligra: 3.0

Nov 26 2019

mphilippov requested review of D25541: Display figure brackets in plain text.
Nov 26 2019, 9:04 AM · Calligra: 3.0

Nov 20 2019

mphilippov requested review of D25423: Fill table cells with color for ODS and XLSX files.
Nov 20 2019, 1:15 PM · Calligra: 3.0
mphilippov requested review of D25422: Handle custom-shapes to display text in ODP files.
Nov 20 2019, 12:52 PM · Calligra: 3.0