In D25423#589481, @pvuorela wrote:Do you mean this "if ()" part of code? If there is no style "graphic" and inner "if" will not execute. Do you mean it'll be better to handle it in this part of code...or what?
The main question was how should the three attributes play together. But another question: why isn't setBackgroundColor enough for the background color?
- Queries
- All Stories
- Search
- Advanced Search
Feed Advanced Search
Advanced Search
Advanced Search
Jan 9 2020
Jan 9 2020
Jan 7 2020
Jan 7 2020
In D25423#589430, @pvuorela wrote:loadTableCellProperties() is a method for applying styles for table cells, i.e. cell background. There is no handling for cell background in the place you mentioned.
I'm talking about handling in that particular method. It will already set background brush in that method later. Why is that not enough?
In D25423#586953, @pvuorela wrote:Not sure about all the details but two things look suspicious here:
- Above this there's handling for transparent and now the handling isn't symmetric for background brush.
- There's some handling on the file for KoXmlNs::draw / style-name & KoXmlNs::calligra / fill-style-name which do background brush setting. What's the relation between these three?
Dec 31 2019
Dec 31 2019
Dec 2 2019
Dec 2 2019
mphilippov added reviewers for D25422: Handle custom-shapes to display text in ODP files: pvuorela, dcaliste.
Nov 26 2019
Nov 26 2019
Nov 20 2019
Nov 20 2019