Differential D3992

Sync kicker tooltip icon to config setting
ClosedPublic
Actions

Authored by davidedmundson on Jan 6 2017, 4:08 PM.

Details

Reviewers
mart
Group Reviewers
Plasma
Commits
R119:f37c2ea93dd0: Sync kicker tooltip icon to config setting
Summary

BUG: 368912

Test Plan

Set it to a non-square image.
Checked it looked fine.

Unchecked "use custom image". icon restored as before.

Code is effectiely the same as kickoff.

Diff Detail

Repository
R119 Plasma Desktop
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
davidedmundson updated this revision to Diff 9801.Jan 6 2017, 4:08 PM
davidedmundson retitled this revision from to Sync kicker tooltip icon to config setting.
davidedmundson updated this object.
davidedmundson edited the test plan for this revision. (Show Details)
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptJan 6 2017, 4:08 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart accepted this revision.Jan 6 2017, 4:16 PM
mart added a reviewer: mart.
This revision is now accepted and ready to land.Jan 6 2017, 4:16 PM
broulik added a subscriber: broulik.Jan 6 2017, 4:17 PM

Patch looking fine but Eike had some reservations as the square icon stuff isn't in a version Plasma-desktop depends on, it might be running against the previous version where it will look crap.

davidedmundson added a comment.Jan 6 2017, 4:44 PM
In D3992#74676, @broulik wrote:

Patch looking fine but Eike had some reservations as the square icon stuff isn't in a version Plasma-desktop depends on, it might be running against the previous version where it will look crap.

Yeah, I saw that.

I'm ok with waiting till 5.10, but personally I feel it'd be such a tiny problem affecting such a tiny userbase that it outweighs the current bug.

Closed by commit R119:f37c2ea93dd0: Sync kicker tooltip icon to config setting (authored by davidedmundson). · Explain WhyJan 16 2017, 10:51 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 9801

View Options

applets/kicker/package/contents/ui/main.qml

Loading...