Differential D3610

Delete the properties window if closed
ClosedPublic
Actions

Authored by maximilianocuria on Dec 6 2016, 7:33 PM.

Details

Reviewers
knauss
dvratil
Group Reviewers
KDE PIM
Summary

This should allow the window to be created again on request.

Test Plan

It works for me

Diff Detail

Repository
R165 Akonadi
Branch
delete_on_close
Lint
No Linters Available
Unit
No Unit Test Coverage
maximilianocuria updated this revision to Diff 8821.Dec 6 2016, 7:33 PM
maximilianocuria retitled this revision from to Delete the properties window if closed.
maximilianocuria updated this object.
maximilianocuria edited the test plan for this revision. (Show Details)
Restricted Application added a project: KDE PIM. · View Herald TranscriptDec 6 2016, 7:33 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
maximilianocuria added reviewers: KDE PIM, knauss.Dec 6 2016, 7:37 PM

Hi,

This commit fixed the Debian bug reported in: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=845553

Happy hacking,

knauss edited edge metadata.Dec 6 2016, 7:43 PM

please use keywords in the commit log https://community.kde.org/Policies/Commit_Policy#Special_keywords_in_GIT_and_SVN_log_messages:

Bug: 373363
FIXED-IN: 5.X.X

^^either 5.5.0 is end up in master or 5.4.0 if it is Applications/16.12

dvratil accepted this revision.Dec 7 2016, 9:45 AM
dvratil added a reviewer: dvratil.
dvratil added a subscriber: dvratil.

Please update the commit message as requested by Sandro and you can commit this to Applications/16.12 branch (so FIXED-IN: 5.4.0)

This revision is now accepted and ready to land.Dec 7 2016, 9:45 AM

Revision Contents
Changeset List

Diff 8821

View Options

src/widgets/collectionpropertiesdialog.cpp

Loading...