Differential D29628

Use the right targets for KSysGuard
ClosedPublic
Actions

Authored by ahiemstra on May 11 2020, 11:33 AM.

Tags

Subscribers

meven, plasma-devel

Details

Reviewers

Group Reviewers

Commits

R120:8ae9b561c82f: Use the right targets for KSysGuard

Summary

Otherwise the build fails when things try to link to KF5::SysGuard etc.

Test Plan

Builds again

Diff Detail

Repository

R120 Plasma Workspace

Branch

ksysguard_targets

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 26697
Build 26715: arc lint + arc unit

ahiemstra created this revision.May 11 2020, 11:33 AM

Restricted Application added a project: Plasma. · View Herald TranscriptMay 11 2020, 11:33 AM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

ahiemstra requested review of this revision.May 11 2020, 11:33 AM

Harbormaster completed remote builds in B26694: Diff 82513.May 11 2020, 11:33 AM

It miss a KSysGuard::ProcessCore in applets/systemmonitor/systemmonitor/CMakeLists.txt

This revision now requires changes to proceed.May 11 2020, 12:24 PM

ANd KSysGuard::Sensors KSysGuard::SensorFaces in applets/systemmonitor/systemmonitor/CMakeLists.txt

Also change system monitor plasmoid

Harbormaster completed remote builds in B26697: Diff 82516.May 11 2020, 12:31 PM

Tested, LGTM

This revision is now accepted and ready to land.May 11 2020, 12:34 PM

Related fix in plasma-desktop D29626

Closed by commit R120:8ae9b561c82f: Use the right targets for KSysGuard (authored by ahiemstra). · Explain WhyMay 11 2020, 12:48 PM

This revision was automatically updated to reflect the committed changes.

meven mentioned this in D29623: Fix Warning about KF5::KSysGuard target being deprecated.May 11 2020, 1:00 PM

Revision Contents
Changeset List

			Path	Packages
M			CMakeLists.txt (2 lines)
M			applets/systemmonitor/systemmonitor/CMakeLists.txt (6 lines)
M			dataengines/devicenotifications/CMakeLists.txt (2 lines)
M			dataengines/systemmonitor/CMakeLists.txt (2 lines)
M			runners/kill/CMakeLists.txt (2 lines)
M			systemmonitor/CMakeLists.txt (2 lines)

Diff 82516

CMakeLists.txt

Loading...

applets/systemmonitor/systemmonitor/CMakeLists.txt

Loading...

dataengines/devicenotifications/CMakeLists.txt

Loading...

dataengines/systemmonitor/CMakeLists.txt

Loading...

runners/kill/CMakeLists.txt

Loading...

systemmonitor/CMakeLists.txt

Loading...