Differential D29623

Fix Warning about KF5::KSysGuard target being deprecated
ClosedPublic
Actions

Authored by meven on May 11 2020, 10:54 AM.

Details

Reviewers
ahiemstra
davidedmundson
Group Reviewers
Plasma
Commits
R120:d2c57378479a: Fix Warning about KF5::KSysGuard target being deprecated
Summary

Warnings such as:

CMake Warning at /usr/lib/x86_64-linux-gnu/cmake/KF5SysGuard/KF5SysGuardConfig.cmake:37 (me
ssage):
  The KF5:: namespace for KSysGuard targets is deprecated.  Please use
   KSysGuard as namespace.
 Call Stack (most recent call first):
   /usr/share/ECM/find-modules/FindKF5.cmake:74 (find_package)
   CMakeLists.txt:55 (find_package)
Test Plan

cmake does not output those warnings

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
meven created this revision.May 11 2020, 10:54 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 11 2020, 10:54 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
meven requested review of this revision.May 11 2020, 10:54 AM
davidedmundson accepted this revision.May 11 2020, 10:57 AM
This revision is now accepted and ready to land.May 11 2020, 10:57 AM
Closed by commit R120:d2c57378479a: Fix Warning about KF5::KSysGuard target being deprecated (authored by meven). · Explain WhyMay 11 2020, 10:58 AM
This revision was automatically updated to reflect the committed changes.
ahiemstra added a comment.May 11 2020, 11:13 AM

Uh, I'm not sure how this fixes anything? It'll remove the warning but it means anything using the previous KF5:: namespaced targets is now broken. So this at least needs a follow up to change those usages.

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (2 lines)

Diff 82506

View Options

CMakeLists.txt

Loading...