- moved to activity config
- fixed issue of skipping levels after clicking save button multiple times
Details
- Reviewers
jjazeix - Group Reviewers
GCompris: Improvements
Diff Detail
- Repository
- R2 GCompris
- Branch
- multiple_dataset
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 24513 Build 24531: arc lint + arc unit
There is one more bug in the acitivity, changing setting resets the coordinates but does not erase line segments. can you please check and confirm it?
src/activities/number_sequence/number_sequence.js | ||
---|---|---|
153 | instead of changing it twice in initLevel and in won, would it be better to always connect the signal in Bonus to an internal slot and in this slot, check if mode == 1. If yes, we call Activity.nextLevel? |
src/activities/number_sequence/NumberSequence.qml | ||
---|---|---|
278 | a if() is way clearer, why using a ternary here? |
I just tested it again more closely.
This activity is inherited by:
clickanddraw/Clickanddraw.qml:27:NumberSequence {
drawletters/Drawletters.qml:26:NumberSequence {
We also need to add the configuration on both activities.
- clickanddraw and drawletters, move config to activity config(multiple dataset style)
- drawnumbers, move config to activity config (multiple_dataset style)
src/activities/number_sequence/number_sequence.js | ||
---|---|---|
85 | In which case are we not in one of these cases? |
src/activities/number_sequence/number_sequence.js | ||
---|---|---|
85 | for none :( |
On a second look, I noticed there is no need to call initLevel() function from Activity config, so removed it.
If you don't do it, it does not reinitialize the level when changing the configuration. Maybe, doing the same as gletters, with onStart: background.stop(), background.start() will be enough?