Between default animation speed and slower/faster, there is a huge change.
Making the slider change from 0.5 instead of one,
makes the speed of animation change in much smaller changes
Details
Details
- Reviewers
ngraham davidedmundson broulik - Group Reviewers
Plasma VDG - Commits
- R119:06abda3d429b: Make the animation slider more granular
Diff Detail
Diff Detail
- Repository
- R119 Plasma Desktop
- Branch
- more-granular-animation-speed-slider (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 23711 Build 23729: arc lint + arc unit
Comment Actions
More info: as discussed here: https://www.reddit.com/r/kde/comments/fgwcou/tip_animation_speedslider/
Also, please, be gentle, this is the first time doing tasks on phabricator and using arcanist. If i am doing something wrong, please ELI5
Comment Actions
Seems reasonable to me. I agree that the current steps are not quite granular enough for people who just want to tweak the default settings a little bit.
@davidedmundson, thoughts?
Comment Actions
Change is fine, we deliberately store the value as the raw float to allow any UI separation.
Thanks for your first patch. You did everything right. Good stuff.
Comment Actions
thank you all for the positive feedback :)
I am not a kde dev ( don't have a developer account ). I will try to apply for one, but in the meanwhile, anyone could land this?