Ref T12339
- I have added an extra hint for the position of planets , this rhyme can help students learn positions easily
- Now hints will be displayed to only particular questions
jjazeix |
GCompris: Improvements |
Ref T12339
Lint Skipped |
Unit Tests Skipped |
src/activities/solar_system/SolarSystem.qml | ||
---|---|---|
308 | a single ! is enough. |
No need to remove the hint, but please add context for translators.
src/activities/solar_system/SolarSystem.qml | ||
---|---|---|
290 | After a bit of search I guess it should be possible to find similar equivalent in all languages. |
There is an issue with the patch, it shouldn't be displayed like that. We should have a diff of all the files separately.
mypatch.patch | ||
---|---|---|
416 ↗ | (On Diff #77507) | Please, add space around ===, remove the one before ), and add a space between ) and {. |
418 ↗ | (On Diff #77507) | indentation |
419 ↗ | (On Diff #77507) | add space after else |
419 ↗ | (On Diff #77507) | it may be better to not having the hint button displayed when there are no hints available instead of having a hint button saying there is no hint. |
420 ↗ | (On Diff #77507) | use camelCase for naming variables (noHintDialog, hintProvided) |
Can you please help me on how to make changes in the bar with each changing question ? Also sorry for the late reply
I am not getting how to make change in bar as you change a question , I think because content of bar depends on the planet you choose
Instead of having a js variable Activity.hintprovide, you can have it in qml object "items".
There are already several BarEnumContent with or without hints, you can use the good one depending on the value of hintprovide
I think now its working properly , hint button is displaying only for particular questions
src/activities/solar_system/SolarSystem.qml | ||
---|---|---|
83 | hintProvided instead of hintprovide everywhere please |
src/activities/solar_system/Dataset.js | ||
---|---|---|
32 ↗ | (On Diff #78223) | it is better to use true or false for boolean values |
Hi, under which name should I commit? "FirstName LastName <email>" for the syntax :)
src/activities/solar_system/SolarSystem.qml | ||
---|---|---|
394 | it should not be needed as we should not display the hint icon if no hint is provided (meaning we can't click on it) |
thanks, commited in b0592dbc7f54bcaba0cb1cde3f36beb2185b1555
src/activities/solar_system/SolarSystem.qml | ||
---|---|---|
394 | I'll do the change when commiting, don't bother changing it |