Differential D27664

Improve layout and appearance of app details view
ClosedPublic
Actions

Authored by ngraham on Feb 25 2020, 9:45 PM.

Details

Reviewers
apol
ndavis
Group Reviewers
VDG
Discover Software Store
Commits
R134:9b0652d5c724: Improve layout and appearance of app details view
Summary

After porting to FormLayout in D27183, the layout can now be so wide due to the URLs
that it switches to the compact/mobile view. This patch re-arranges things a bit and
uses human-readable strings for the links instead of showing raw URLs. For safety,
this requires D27663 to be implemented first.

BUG: 418019
FIXED-IN: 5.19.0
Depends on D27663

Test Plan

Before: normal-sized window (shows the compact/mobile view):

Before wide window:

After: normal-sized or wide window:

Diff Detail

Repository
R134 Discover Software Store
Branch
clean-up-app-details (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 22939
Build 22957: arc lint + arc unit
ngraham created this revision.Feb 25 2020, 9:45 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 25 2020, 9:45 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Feb 25 2020, 9:45 PM
ndavis accepted this revision.Feb 25 2020, 10:02 PM
This revision is now accepted and ready to land.Feb 25 2020, 10:02 PM
apol accepted this revision.Feb 25 2020, 11:29 PM
Closed by commit R134:9b0652d5c724: Improve layout and appearance of app details view (authored by ngraham). · Explain WhyMar 6 2020, 6:28 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mdiscover/qml/ApplicationPage.qml (18 lines)

Diff 76423

View Options

discover/qml/ApplicationPage.qml

Loading...