The text was smaller than than minimum configuration, and
also smaller than the width allowed for.
Details
Diff Detail
- Repository
- R120 Plasma Workspace
- Branch
- Plasma/5.18
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 22717 Build 22735: arc lint + arc unit
Fix the logic to what was probably originally meant.
Elided is still disabled as it triggers too aggresively on narrow fits.
Thanks for the patch! Looks like this doesn't fully fix the issue though. With "Short Date" I see the following:
In my case the text was too small.
I wonder how exactly Text.Fit works, if it just increases font-size for short format to fill width that could make it too big.
Well your patch doesn't regress anything for me, so if it fixes it for you, that's good.
Still it might be good to have some clarity here so we understand what's going on! :p
Now using the "Long Date" setting in a double-width panel results in the following:
And "Short Date" looks like this:
font.pixelSize: timeLabel.height * 0.4 doesn't look right to me.