This patch adds condition that input must last more than 2 seconds
before pause duration is reset to its full length during
TimerState::Suggesting phase.
This prevents accidental mouse touches from interrupting pause.
aacid |
This patch adds condition that input must last more than 2 seconds
before pause duration is reset to its full length during
TimerState::Suggesting phase.
This prevents accidental mouse touches from interrupting pause.
No Linters Available |
No Unit Test Coverage |
Buildable 20759 | |
Build 20777: arc lint + arc unit |
Doesn't seem to really work for me.
I mean, yes it works in the sense that the timer doesn't go back to 20 seconds but at the end of my "you should rest" period i always get the "oh you've been bad my not resting" screen if i have used this feature of ignoring a few seconds.
Are you using the popup? (on the settings third panel on the list of the left, option of the bottom)
I'm not sure what doesn't work for you. It seems to work as I intended. Here is how I test it (RSI settings are as at the bottom of this post):
If I would move my mouse for 3 s instead of 1 s at 4) or 6) point, then the countdown would be reset to 60 s which is undesirable.
Are you using the popup? (on the settings third panel on the list of the left, option of the bottom)
Here are my settings
ignore me i was complaining about a different behaviour that we already have in master and it's not introduced by this patch ^_^
You're welcome, but what about the other revision, that I've sent you for a review?
Add length columns to CatalogModelColumns
Is it on your to-do list?
Is it on your to-do list?
Kind of, but my "review things for lokalize" priority is much smaller than "review things for rsibreak", i'm mostly hoping someone else picks it up, but if not i'll pick it up eventually
Hi @aacid & @wojnilowicz:
unfortunately this commit breaks the rsibreak_tests:
FAIL! : RSITimerTest::triggerSimpleBigBreak() Compared values are not the same Actual (spy1Relax.count()): 100 Expected (relaxCountExp) : 97 Loc: [SRCDIR/test/rsitimer_test.cpp(186)]
Can you please look into both the issues? Thanks!
This patch fixes the rsibreak_tests crash, however the test still fails in RSITimerTest::triggerSimpleBigBreak(), in the way I already mentioned.
Thank you for testing. Somehow I didn't notice the second failure. I've decided to post a solution in the another review .