Differential D26300

Port endl to \n as QTextStream is flushed at the end. endl is namespaced in qt5.15
ClosedPublic
Actions

Authored by mlaurent on Dec 30 2019, 8:24 PM.

Details

Reviewers
dfaure
apol
Commits
R301:8587c249f5c8: Port endl to \n as QTextStream is flushed at the end. endl is namespaced in qt5.
Summary

Port endl to \n for compiling against qt5.15

Diff Detail

Repository
R301 KEmoticons
Branch
port_endl_qt5.15 (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 20474
Build 20492: arc lint + arc unit
mlaurent created this revision.Dec 30 2019, 8:24 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptDec 30 2019, 8:24 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
mlaurent requested review of this revision.Dec 30 2019, 8:24 PM
apol accepted this revision.Dec 31 2019, 6:40 PM
apol added a subscriber: apol.
apol added inline comments.
src/providers/pidgin/pidgin_emoticons.cpp
221

Put it in the same string as "Author=\n"? Or at least use '\n'.

This revision is now accepted and ready to land.Dec 31 2019, 6:40 PM
mlaurent updated this revision to Diff 72515.Jan 1 2020, 9:45 AM

Merge \n

Closed by commit R301:8587c249f5c8: Port endl to \n as QTextStream is flushed at the end. endl is namespaced in qt5. (authored by mlaurent). · Explain WhyJan 1 2020, 9:45 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 72515

View Options

src/providers/pidgin/pidgin_emoticons.cpp

Loading...