Most of this code is lifted straight from the file indexing monitor KInfoCenter KCM.
If and when this lands, that becomes largely redundant and we could consider removing it.
Depends on D25743
FEATURE: 374474
FEATURE: 405307
FIXED-IN: 5.19.0
bruns | |
davidedmundson |
VDG | |
Plasma | |
Baloo |
Most of this code is lifted straight from the file indexing monitor KInfoCenter KCM.
If and when this lands, that becomes largely redundant and we could consider removing it.
Depends on D25743
FEATURE: 374474
FEATURE: 405307
FIXED-IN: 5.19.0
Everything seems to work.
No Linters Available |
No Unit Test Coverage |
Buildable 19486 | |
Build 19504: arc lint + arc unit |
For the concept a big +1 from me. I did not even know that we had that in the infocenter...
I think most people don't know this, because it's an odd place to have controls to start and stop indexing. If and when this patch lands, I think we could consider removing the Baloo page entirely.
kcms/baloo/package/contents/ui/main.qml | ||
---|---|---|
93 | what about: LowPowerIdle? |
kcms/baloo/package/contents/ui/constants.js | ||
---|---|---|
24 | I'm not sure exactly what that means or how to do it; can you help me with it? |
kcms/baloo/package/contents/ui/main.qml | ||
---|---|---|
82 | This is the wrong way round |
kcms/baloo/package/contents/ui/main.qml | ||
---|---|---|
82 | Edit, no it wasn't wrong But I have found what is. I export this as the class Baloo, but the import is also under Baloo So for this to work against my patch it would be Baloo.Baloo.Suspended |
Thanks @davidedmundson. There's one more FIXME in the code that I could use your help with, if you don't mind.
kcms/baloo/package/contents/ui/main.qml | ||
---|---|---|
94 | Monitor's property is called state. Lowercase S. A switch statement here might make this a bit easier to read. |
kcms/baloo/package/contents/ui/main.qml | ||
---|---|---|
94 | Done, but now opening the KCM prints a ton of these errors: QMetaProperty::read: Unable to handle unregistered datatype 'Baloo::IndexerState' for property 'Baloo::Monitor::state' |
kcms/baloo/package/contents/ui/main.qml | ||
---|---|---|
82 |
This isn't in this diff |
That turned out to be an unrelated Baloo bug that was recently fixed by D27326.
This is ready for re-review.