Differential D25098

Don't set QGraphicsView::DontClipPainter anymore
AcceptedPublic
Actions

Authored by heikobecker on Oct 31 2019, 6:42 PM.

Details

Reviewers
aacid
Group Reviewers
KDE Games
Summary

It's obsolete, has no effect anymore and is marked as
deprecated since Qt 5.14, causing a build failure because of
"-DQT_DISABLE_DEPRECATED_BEFORE=0x060000".

While at it also remove a comment about an old bug.

Test Plan

Builds fine against Qt 5.14

Diff Detail

Repository
R389 KAtomic
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 18402
Build 18420: arc lint + arc unit
heikobecker created this revision.Oct 31 2019, 6:42 PM
Restricted Application added a subscriber: kde-games-devel. · View Herald TranscriptOct 31 2019, 6:42 PM
heikobecker requested review of this revision.Oct 31 2019, 6:42 PM
aacid added a subscriber: aacid.Oct 31 2019, 8:59 PM

Have you checked introducing DontSavePainterState doesn't cause any graphical issues? (your test plan doesn't say so)

heikobecker added a comment.Nov 1 2019, 9:36 AM
In D25098#557440, @aacid wrote:

Have you checked introducing DontSavePainterState doesn't cause any graphical issues? (your test plan doesn't say so)

Yes, I didn't notice any glitches here.

aacid accepted this revision.Nov 2 2019, 12:35 PM

ok :)

This revision is now accepted and ready to land.Nov 2 2019, 12:35 PM

Revision Contents
Changeset List

PathPackages
Mgamewidget.cpp (6 lines)

Diff 69129

View Options

gamewidget.cpp

Loading...