Don't set QGraphicsView::DontClipPainter anymore
AcceptedPublic

Authored by heikobecker on Thu, Oct 31, 6:42 PM.

Details

Reviewers
aacid
Group Reviewers
KDE Games
Summary

It's obsolete, has no effect anymore and is marked as
deprecated since Qt 5.14, causing a build failure because of
"-DQT_DISABLE_DEPRECATED_BEFORE=0x060000".

While at it also remove a comment about an old bug.

Test Plan

Builds fine against Qt 5.14

Diff Detail

Repository
R389 KAtomic
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 18402
Build 18420: arc lint + arc unit
heikobecker created this revision.Thu, Oct 31, 6:42 PM
Restricted Application added a subscriber: kde-games-devel. · View Herald TranscriptThu, Oct 31, 6:42 PM
heikobecker requested review of this revision.Thu, Oct 31, 6:42 PM
aacid added a subscriber: aacid.Thu, Oct 31, 8:59 PM

Have you checked introducing DontSavePainterState doesn't cause any graphical issues? (your test plan doesn't say so)

Have you checked introducing DontSavePainterState doesn't cause any graphical issues? (your test plan doesn't say so)

Yes, I didn't notice any glitches here.

aacid accepted this revision.Sat, Nov 2, 12:35 PM

ok :)

This revision is now accepted and ready to land.Sat, Nov 2, 12:35 PM