Differential D23912

Respect .hidden files
ClosedPublic
Actions

Authored by gengisdave on Sep 12 2019, 5:04 PM.

Details

Reviewers
asensi
Group Reviewers
Krusader
Commits
R167:97016770f6a6: Respect .hidden files
Summary

The patch hide all the elements contained in the .hidden file.

This is taken from the KIO implementation made by Bruno Nova.

FIXED: [ 396659 ] Respect .hidden files
BUG: 396659

Test Plan

Entries in .hidden file must be hidden when "Show Hidden Files" (Alt+.) is not active. When this is active, there are no differences if the entry exists or not.

Diff Detail

Repository
R167 Krusader
Lint
Lint Skipped
Unit
Unit Tests Skipped
gengisdave requested review of this revision.Sep 12 2019, 5:04 PM
gengisdave created this revision.
asensi added a subscriber: asensi.Sep 15 2019, 3:44 PM

The new code works using Kubuntu 18.04. Other people can do their checks. Thanks, Davide!

asensi accepted this revision as: asensi.Sep 15 2019, 9:36 PM
This revision is now accepted and ready to land.Sep 15 2019, 9:36 PM
Closed by commit R167:97016770f6a6: Respect .hidden files (authored by gengisdave). · Explain WhyMay 4 2020, 9:43 PM
This revision was automatically updated to reflect the committed changes.
asensi added a comment.EditedMay 4 2020, 10:59 PM

That's good!

A mention of that change also should be finally added to the ChangeLog file.
What about
ADDED: When "Show Hidden Files" option is disabled: hide files and folders specified in each ".hidden" file.
?

gengisdave added a comment.May 5 2020, 6:48 AM

Yes, thanks.

I always forget to update the ChangeLog

Revision Contents
Changeset List

Diff 65935

View Options

krusader/FileSystem/defaultfilesystem.h

Loading...
View Options

krusader/FileSystem/defaultfilesystem.cpp

Loading...