Use QIcon instead of QPixmap for icons. Use QPushButton for the filter menu instead of a QLabel.
Depends on D23942
ngraham |
Plasma |
Use QIcon instead of QPixmap for icons. Use QPushButton for the filter menu instead of a QLabel.
Depends on D23942
No Linters Available |
No Unit Test Coverage |
Buildable 16369 | |
Build 16387: arc lint + arc unit |
Either use a ToolButton for the filter feature, or turn "Scan for duplicate fonts" into a PushButton, so they match one way or another.
Maybe in the interests of Goal: Consistency, let's make the filter feature look the same way that it does in the Colors KCM:
There is a major difference: the color filter is a combobox but the font filter is a menu with checkbox and child menu. I cannot change it to a combobox but can swap the order and try to add borders.
Radio buttons, not checkboxes. Which means the entries are all mutually exclusive, which means it could actually be a combobox, but for the fact that some of its items have sub-menus.
Now I can get something like this (the QLineEdit and QPushButton still have different height):
Similar filter layout as Colors KCM. Move "Scan Duplicates..." button to the bottom button group.
Also improved spacing in filter bar.
Uh-oh, moving the button down to the lower row now causes the layout to get so wide with English that it overflows the default System Settings window size:
.Avoid scrollbar. Put progressbar and font status to another row.
Some weird layout when increase the height to very big:
Rename Scan Duplicates... to Find Duplicates... and move the button to the left of Install from File... and then I think this will be good.