Details
Details
Diff Detail
Diff Detail
- Repository
- R159 KActivities Statistics
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 15572 Build 15590: arc lint + arc unit
src/query.h | ||
---|---|---|
105 | I screwed up the names - plurals vs singulars here as Agent can contain several agents - having Agent::current looked better than Agents::current. We'll need to do something about this for Qt6/KF6. Now, I can not guarantee this, but I think we will have a smaller API change if these were all named in plural. In that case, with the implicit conversion from QStringList to Agent and others, only one set function should be needed for each of these. So void setTypes(const Terms::Type &types); instead of void setTypes(const QStringList &types); void setType(const Terms::Type &types); What do you think? |
src/query.h | ||
---|---|---|
105 | That works |
src/query.h | ||
---|---|---|
101 | Please add "@since 6.62" to all this new API, so consumers of them know which min version of KActivitiesStat they need to require to be able to rely on their existance. |
src/query.h | ||
---|---|---|
101 | "5.62" of course :) |