When there is only one tab and a process is running, remove the
'close current tab' option when attempting to close Konsole.
Details
Details
- Reviewers
hindenburg - Group Reviewers
Konsole - Commits
- R319:276a6dca6602: In confirm close dialog, remove 'close current tab' option
- Open Konsole (assuming you have not check 'Do not ask again')
- Start any process (ie top)
- Try to close Konsole
Should only be 2 options, 'Close window' and 'Cancel'
Diff Detail
Diff Detail
- Repository
- R319 Konsole
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Hmm, can you explain why you think this is an improvement? To me it seems sensible enough to warn people that closing a tab (even if it's the only tab) will kill the running program.
Comment Actions
Sorry. Probably, I didn't explain my idea clear enough. When you close konsole with the running program the warning dialog gives you 3 options: "Close Window", "Close Current Tab", "Cancel". If there is only one tab, than the option "Close Current Tab" is equal to "Close Window". So we have 2 options to close konsole. My patch leaves only "Close Window" and "Cancel" for that case.