In confirm close dialog, remove 'close current tab' option
ClosedPublic

Authored by AndreyYashkin on Wed, Aug 14, 9:08 AM.

Details

Summary

When there is only one tab and a process is running, remove the
'close current tab' option when attempting to close Konsole.

Test Plan
  1. Open Konsole (assuming you have not check 'Do not ask again')
  2. Start any process (ie top)
  3. Try to close Konsole

Should only be 2 options, 'Close window' and 'Cancel'

Diff Detail

Repository
R319 Konsole
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
AndreyYashkin requested review of this revision.Wed, Aug 14, 9:08 AM
AndreyYashkin created this revision.

Hmm, can you explain why you think this is an improvement? To me it seems sensible enough to warn people that closing a tab (even if it's the only tab) will kill the running program.

Hmm, can you explain why you think this is an improvement? To me it seems sensible enough to warn people that closing a tab (even if it's the only tab) will kill the running program.

Sorry. Probably, I didn't explain my idea clear enough. When you close konsole with the running program the warning dialog gives you 3 options: "Close Window", "Close Current Tab", "Cancel". If there is only one tab, than the option "Close Current Tab" is equal to "Close Window". So we have 2 options to close konsole. My patch leaves only "Close Window" and "Cancel" for that case.

Oh I see! +1 then.

hindenburg retitled this revision from Do not ask to close current tab with running process if it is the only tab to In confirm close dialog, remove 'close current tab' option.Fri, Aug 16, 3:41 PM
hindenburg edited the summary of this revision. (Show Details)
hindenburg edited the test plan for this revision. (Show Details)
hindenburg accepted this revision.Fri, Aug 16, 3:46 PM
hindenburg added a subscriber: hindenburg.

thanks

This revision is now accepted and ready to land.Fri, Aug 16, 3:46 PM
This revision was automatically updated to reflect the committed changes.