BUG: 391207
Details
Diff Detail
- Repository
- R40 Kate
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Actually I am not sure if we want this behavior at all.
Most config dialogs don't do this.
Ok, yes, you are right. And I assume the code is copied from there, or? Which is actually license incompatible, as the code is ATM LGPL v2+, not GPL.
For the actual implementation: m_unsavedChange seems to be not needed, as we have m_dataChanged, or?
+1 for fixing the bug, but I'm left wondering if it makes sense to require every settings window to reinvent the wheel like this. Couldn't we add this kind of logic globally into the KPageDialog, maybe?
That way if we ever decide that these dialogs are annoying, we can turn them off in one place rather than having each app wind up with inconsistent behavior.
I would be ok to merge this, thought I don't know if the license is ok, given that is a 1:1 copy from the other program, or?
Then the license doesn't match, if I don't misread the license headers of the file you copied it from and ours.
I see even though wording are not same, they both mean the same thing. ie.(GNU GPL)?So what to do?
The license in dolphin says "you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version".
either version 2 of the License, or (at your option) any later version
I think this means v2+.
I will try asking Peter Penz, however I doubt he is still active.
Our dialog is "GNU Library General Public".
And I assume that code is new, as in the 19.04 version I had dolphin didn't ask ;=)
Given the code is trivial (a message box with two sentences) I assume we can merge this disregarding gpl/lgpl.