the file was unusable due to bogus version name, missing dependencies and wrong paths.
Details
Details
- Reviewers
- None
- Commits
- R235:134e0290cc2f: Fix the attica pkgconfig file.
Before:
prefix=/data/kde/inst exec_prefix=/data/kde/inst/bin libdir=lib64 includedir=include/KF5Attica Name: libKF5Attica Description: Qt library to access Open Collaboration Services #Requires: Version: .. Libs: -Llib64 -lKF5Attica Cflags: -Iinclude/KF5Attica
After:
prefix=/data/kde/inst
exec_prefix=${prefix}
libdir=/data/kde/inst/lib64
includedir=/data/kde/inst/include
Name: libKF5Attica
Description: Qt library to access Open Collaboration Services
URL: https://www.kde.org
Requires: Qt5Core Qt5Network
Version: 5.61.0
Libs: -L/data/kde/inst/lib64 -lKF5Attica
Cflags: -I/data/kde/inst/include/KF5/AtticaDiff Detail
Diff Detail
- Repository
- R235 Attica
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 14878 Build 14896: arc lint + arc unit
Comment Actions
Note: the ecm_generate_pkgconfig_file macro cannot be used since it doesn't support extra CFLAGS (yet)
| src/cmake/libKF5Attica.pc.cmake | ||
|---|---|---|
| 0–1 | In ECM and Qt this is absolute, ${prefix}/lib64, same for exec_prefix. | |
Comment Actions
use ${prefix} for the exec line.
For the others, it's a bit trickier since you can use either relative or
absolute paths when calling CMake.
This will be handled when the ECM macro gets updated.
Comment Actions
You seem to have not set any reviewers on this... It seems fine to me, but pkgconfig isn't really my forte :)