Add a Term Date to Query to filter on ResourceEvent start column when querying for resources.
Add two special cases : today and yesterday
Details
- Reviewers
ivan - Group Reviewers
Frameworks - Commits
- R159:bdba31fac999: Add Date term to KActivities Stats to filter on resource event date
Manual through the test app
autotest
Diff Detail
- Repository
- R159 KActivities Statistics
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Joining with ResourceEvent is a problem. At least make it not get joined if the date filter is not present.
autotests/QueryTest.h | ||
---|---|---|
54 | tes -> test | |
src/resultset.cpp | ||
182 | setDate above is by value, here it is const-ref. Check for the size of the type and decide on one of these. | |
313 | This is a potential efficiency problem - ResourceEvent is the quickest growing table. I don't like the idea for it to always be joined. | |
422 | Also, add an empty line above - I know I like empty lines too much, but ... :) |
src/resultset.cpp | ||
---|---|---|
182 | QDate size is 8 byte, so on most systems nowadays it will equal to a ref size, so I am opting towards the simpler and more stable one : by value. |
src/resultset.cpp | ||
---|---|---|
293–299 | Any reason for the rename? |
src/resultset.cpp | ||
---|---|---|
293–299 | It is so that the ResourceEvent join in resourceEventJoinClause works with every sql request. |