Details

Reviewers

Group Reviewers

Commits

R159:bdba31fac999: Add Date term to KActivities Stats to filter on resource event date

Summary

Add a Term Date to Query to filter on ResourceEvent start column when querying for resources.
Add two special cases : today and yesterday

Test Plan

Manual through the test app
autotest

Diff Detail

Repository

R159 KActivities Statistics

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

meven created this revision.Jul 24 2019, 1:54 PM

Restricted Application added a project: Frameworks. · View Herald TranscriptJul 24 2019, 1:54 PM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

meven requested review of this revision.Jul 24 2019, 1:54 PM

Harbormaster completed remote builds in B14370: Diff 62472.Jul 24 2019, 1:54 PM

Improve sql padding

Harbormaster completed remote builds in B14371: Diff 62473.Jul 24 2019, 2:11 PM

Joining with ResourceEvent is a problem. At least make it not get joined if the date filter is not present.

autotests/QueryTest.h
54	tes -> test
src/resultset.cpp
182	setDate above is by value, here it is const-ref. Check for the size of the type and decide on one of these.
313	This is a potential efficiency problem - ResourceEvent is the quickest growing table. I don't like the idea for it to always be joined.
422	Also, add an empty line above - I know I like empty lines too much, but ... :)

This revision now requires changes to proceed.Jul 24 2019, 8:02 PM

Optionaly join with ResourceEvent when date filtering is being used, review feedback

Harbormaster completed remote builds in B14398: Diff 62520.Jul 25 2019, 7:38 AM

meven marked an inline comment as done.Jul 25 2019, 7:40 AM

meven added inline comments.

src/resultset.cpp
182	QDate size is 8 byte, so on most systems nowadays it will equal to a ref size, so I am opting towards the simpler and more stable one : by value.

meven marked 2 inline comments as done.Jul 25 2019, 7:41 AM

Add an automated test on date filtering

Harbormaster completed remote builds in B14399: Diff 62522.Jul 25 2019, 8:15 AM

meven edited the test plan for this revision. (Show Details)Jul 25 2019, 8:42 AM

meven marked an inline comment as done.

ivan added inline comments.Jul 25 2019, 5:20 PM

src/resultset.cpp
293–299	Any reason for the rename?

meven marked 3 inline comments as done.Jul 25 2019, 5:45 PM

meven added inline comments.

src/resultset.cpp
293–299	It is so that the ResourceEvent join in resourceEventJoinClause works with every sql request. Other wise I would have needed a parameter or multiple functions to make the left join work.

meven marked 2 inline comments as done.Jul 25 2019, 5:46 PM

ivan accepted this revision.Jul 27 2019, 5:10 AM

This revision is now accepted and ready to land.Jul 27 2019, 5:10 AM

meven edited the summary of this revision. (Show Details)Jul 27 2019, 6:48 AM

Closed by commit R159:bdba31fac999: Add Date term to KActivities Stats to filter on resource event date (authored by meven). · Explain WhyJul 27 2019, 6:49 AM

This revision was automatically updated to reflect the committed changes.

meven mentioned this in D22775: Allow date range filtering of resource events using Date Term.Jul 27 2019, 11:05 AM

meven mentioned this in D7446: [Places panel] Revamp the Recently Saved section.Jul 29 2019, 7:33 AM

meven mentioned this in R159:b64cfb3952ee: Allow date range filtering of resource events using Date Term.Aug 22 2019, 7:39 PM

meven mentioned this in D26798: Fix broken SQL query in allResourcesQuery.Jan 20 2020, 6:46 PM

meven added inline comments.Jan 20 2020, 6:48 PM

src/resultset.cpp
399	Missing table name update fix in D26798

meven mentioned this in R159:e36497a6734d: Fix broken SQL query in allResourcesQuery.Jan 20 2020, 9:17 PM

			Path	Packages
M			autotests/QueryTest.h (1 line)
M			autotests/QueryTest.cpp (18 lines)
M			autotests/ResultSetTest.cpp (28 lines)
M			src/query.h (7 lines)
M			src/query.cpp (16 lines)
M			src/resultset.cpp (112 lines)
M			src/terms.h (16 lines)
M			src/terms.cpp (23 lines)
M			tests/model/window.cpp (9 lines)
M			tests/model/window.ui (32 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	62472	d8d2866		Jul 24 2019, 1:54 PM	★	★
Diff 2	62473	d8d2866	Improve sql padding	Jul 24 2019, 2:11 PM	★	★
Diff 3	62520	d8d2866	Optionaly join with ResourceEvent when date filtering is being used, review…	Jul 25 2019, 7:38 AM	★	★
Diff 4	62522	d8d2866	Add an automated test on date filtering	Jul 25 2019, 8:15 AM	★	★
Diff 5	62627	d8d2866	R159:bdba31fac9993047321d1b7652137379f28befed	Jul 27 2019, 6:49 AM	★	★

Add Date term to KActivities Stats to filter on resource event date
ClosedPublic
Actions

Details

Diff Detail

Revision Contents
Changeset List

Diff 62627

autotests/QueryTest.h

autotests/QueryTest.cpp

autotests/ResultSetTest.cpp

src/query.h

src/query.cpp

src/resultset.cpp

src/terms.h

src/terms.cpp

tests/model/window.cpp

tests/model/window.ui

Add Date term to KActivities Stats to filter on resource event dateClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 62627

autotests/QueryTest.h

autotests/QueryTest.cpp

autotests/ResultSetTest.cpp

src/query.h

src/query.cpp

src/resultset.cpp

src/terms.h

src/terms.cpp

tests/model/window.cpp

tests/model/window.ui

Add Date term to KActivities Stats to filter on resource event date
ClosedPublic
Actions

Revision Contents
Changeset List