Differential D21675

mobile: fully port to QQC2
ClosedPublic
Actions

Authored by jbbgameich on Jun 8 2019, 6:09 PM.

Details

Reviewers
ngraham
Group Reviewers
Okular
Commits
R223:c1b396af3e9a: mobile: fully port to QQC2
Summary

Remove all QtQuick Controls 1 imports and replace by QtQuick Controls 2

Test Plan

The mobile app behaves just as before

Diff Detail

Repository
R223 Okular
Branch
full-qqc2 (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 12656
Build 12674: arc lint + arc unit
jbbgameich created this revision.Jun 8 2019, 6:09 PM
Restricted Application added a project: Okular. · View Herald TranscriptJun 8 2019, 6:09 PM
Restricted Application added a subscriber: okular-devel. · View Herald Transcript
jbbgameich requested review of this revision.Jun 8 2019, 6:09 PM
ngraham added a subscriber: ngraham.Jun 10 2019, 4:46 PM

+1, but see T10862. QtQuick.Controls 2.x should be imported as QQC2

jbbgameich updated this revision to Diff 59535.Jun 10 2019, 5:08 PM
  • Unify imports
jbbgameich updated this revision to Diff 59536.Jun 10 2019, 5:18 PM
  • mobile: DocumentView: rename QQC2 import
ngraham accepted this revision.Jun 10 2019, 6:49 PM
This revision is now accepted and ready to land.Jun 10 2019, 6:49 PM
Closed by commit R223:c1b396af3e9a: mobile: fully port to QQC2 (authored by jbbgameich). · Explain WhyJun 10 2019, 7:00 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 59536

View Options

mobile/app/package/contents/ui/MainView.qml

Loading...
View Options

mobile/app/package/contents/ui/OkularDrawer.qml

Loading...
View Options

mobile/app/package/contents/ui/TableOfContents.qml

Loading...
View Options

mobile/app/package/contents/ui/Thumbnails.qml

Loading...
View Options

mobile/app/package/contents/ui/ThumbnailsBase.qml

Loading...
View Options

mobile/app/package/contents/ui/TreeDelegate.qml

Loading...
View Options

mobile/components/DocumentView.qml

Loading...