The theme files define themed sounds, but the code does not use them.
This make it work, tested with Europe theme downloaded through KnewStuff.
Details
Details
- Reviewers
aacid - Group Reviewers
KDE Games - Commits
- R391:35ae7d63e71d: Use the theme file defined sounds if they are declared.
Does this need any other action from me to be reviewed?
Thanks.
Diff Detail
Diff Detail
- Repository
- R391 KBlocks
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 12273 Build 12291: arc lint + arc unit
Comment Actions
ther'es some small things as not compating against "" but using isEmpty, but i'll fix that myself when commititng
Comment Actions
Actually no, this is not all good.
The paths only get calculated on app startup not when the theme is changed while the app running.
Can you please fix that?
Comment Actions
You have a memory leak and some other things like the warnings, but i'll fix them myself and commit.
Thanks for the contribution :)
KBlocksSound.cpp | ||
---|---|---|
68 | This is by far *not* a warning |