Differential D21413

Cleanup default filters for baloo-widgets
ClosedPublic
Actions

Authored by astippich on May 26 2019, 8:09 AM.

Details

Reviewers
ngraham
bruns
Commits
R824:3983d80727b4: Cleanup default filters for baloo-widgets
Summary

The property names do not match any names defined in KFileMetaData.
While the intention of the previous filters clearly was to hide most of the EXIF information,
users seem to use the provided information (see bug report), so show most of it.
Hide photo metering mode, photo sharpness and white balance, as they seem to be quite useless.

CCBUG: 343273

Diff Detail

Repository
R824 Baloo Widgets
Branch
default_filter
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 12270
Build 12288: arc lint + arc unit
astippich created this revision.May 26 2019, 8:09 AM
Restricted Application added a project: Baloo. · View Herald TranscriptMay 26 2019, 8:09 AM
Restricted Application added a subscriber: Baloo. · View Herald Transcript
astippich requested review of this revision.May 26 2019, 8:09 AM
astippich updated this revision to Diff 58674.May 26 2019, 8:17 AM
  • use correct camel case names
ngraham added a comment.May 26 2019, 3:39 PM

Seems sensible on its face but I vaguely remember a reason why these were disabled in the past. IIRC something else provided them. Maybe that's no longer the case now though.

astippich added a comment.May 30 2019, 9:07 AM

As far as I see from the code, there is only the information from KFileItem, xattr, and baloo/kfilemetadata used in baloo-widgets. Maybe it is a remainder of the KDE4 days?

astippich updated this revision to Diff 58895.May 30 2019, 10:24 AM
  • also hide photo sharpness
bruns added a comment.May 30 2019, 10:48 AM

hasPart and isPartOf are coming from the SPARQL ontology, used by the former Nepomuk

bruns added a comment.May 30 2019, 10:50 AM

also, when using a range based for loop, we no longer need the nullptr sentinel

astippich updated this revision to Diff 58898.May 30 2019, 11:25 AM
  • remove isPartOf and hasPart
  • use range-based for loop
bruns added inline comments.May 30 2019, 11:31 AM
src/metadatafilter.cpp
65

also unused

bruns accepted this revision.May 30 2019, 11:31 AM
This revision is now accepted and ready to land.May 30 2019, 11:31 AM
astippich updated this revision to Diff 58902.May 30 2019, 11:46 AM
  • remove plainTextContent
astippich edited the summary of this revision. (Show Details)May 30 2019, 11:46 AM
Closed by commit R824:3983d80727b4: Cleanup default filters for baloo-widgets (authored by astippich). · Explain WhyMay 30 2019, 11:47 AM
This revision was automatically updated to reflect the committed changes.
astippich marked an inline comment as done.

Revision Contents
Changeset List

PathPackages
Msrc/metadatafilter.cpp (20 lines)

Diff 58895

View Options

src/metadatafilter.cpp

Loading...