Differential D21465

Forward and log exit code of the nested process
ClosedPublic
Actions

Authored by apol on May 28 2019, 4:43 PM.

Details

Reviewers

zzag

Group Reviewers

KWin

Commits

R108:cd7fae95a4c0: Forward and log exit code of the nested process

Summary

Otherwise it's hard to tell if it failed.

Test Plan

Found out that my session was crashing.

Diff Detail

Repository

R108 KWin

Branch

master

Lint

Lint Skipped

Excuse: x

Unit

No Unit Test Coverage

Build Status

Buildable 12250
Build 12268: arc lint + arc unit

apol created this revision.May 28 2019, 4:43 PM

Restricted Application added a project: KWin. · View Herald TranscriptMay 28 2019, 4:43 PM

Restricted Application added a subscriber: kwin. · View Herald Transcript

apol requested review of this revision.May 28 2019, 4:43 PM

Harbormaster completed remote builds in B12229: Diff 58798.May 28 2019, 4:43 PM

zzag added a subscriber: zzag.May 28 2019, 6:53 PM

zzag added inline comments.

main_wayland.cpp
251–254	From QProcess::exitCode documentation: This value is not valid unless exitStatus() returns NormalExit. Perhaps, we need to do something like this if (status == QProcess::CrashExit) { qWarning() << "Session process has crashed"; QCoreApplication::exit(-1); return; } if (code) { qWarning() << "Session process exited with code" << code; } QCoreApplication::exit(code);

main_wayland.cpp

251–254

From QProcess::exitCode documentation:

This value is not valid unless exitStatus() returns NormalExit.

Perhaps, we need to do something like this

if (status == QProcess::CrashExit) {
    qWarning() << "Session process has crashed";
    QCoreApplication::exit(-1);
    return;
}

if (code) {
    qWarning() << "Session process exited with code" << code;
}

QCoreApplication::exit(code);

Don't expose the code when crashing

Harbormaster completed remote builds in B12250: Diff 58846.May 29 2019, 2:38 PM

zzag accepted this revision.May 29 2019, 2:55 PM

This revision is now accepted and ready to land.May 29 2019, 2:55 PM

Closed by commit R108:cd7fae95a4c0: Forward and log exit code of the nested process (authored by apol). · Explain WhyMay 29 2019, 3:00 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			main_wayland.cpp (14 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	58798	fe27847		May 28 2019, 4:43 PM	★	★
Diff 2	58846	835f3df	Don't expose the code when crashing	May 29 2019, 2:38 PM	★	★
Diff 3	58852	835f3df	R108:cd7fae95a4c0f1c1524a84cebc81fa44bffa17be	May 29 2019, 3:00 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
4b6cbbe3cdbc	2aaf996a111c	835f3dfde95a	Aleix Pol	Forward and log exit code of the nested process (Show More…)	May 28 2019, 4:42 PM

Diff 58846

View Options