Add the bit number to the tooltip
Details
Diff Detail
- Repository
- R353 KCalc
- Branch
- bit_tooltip (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 11083 Build 11101: arc lint + arc unit
Does this hide the existing "Click on a Bit to toggle it." tooltip?
I guess it does, how do you feel about it?
Yes, the "Click on a Bit to toggle it." tooltip only shows when the cursor is not over a bit.
If you want to set the bit 19, for example, it's annoying to have to count the bits to know exactly which is the correct one.
I don't like the idea to show too much information each time the mouse is over a bit button.
Showing the same information over and over again doesn't help and can quickly become annoying.
How about changing the cursor shape to PointingHandCursor while the mouse is over a bit button?
I'm not sure what the best practices are when using cursor shapes.
We don't do that for regular buttons so doesn't seem the best of the ideas to me.
What maybe makes sense is "half-paint" them on mouse over?
I changed the border of the button from 2 to 1 so that it looks more clear when is half-painted.
The on hover looks really great.
Do you think we should also paint in "on hover" even if it's set when the mouse is over it? I'm conflicted
kcalc_bitset.cpp | ||
---|---|---|
95 | we don't use tr but i18n, this should be i18n("Bit %1", bitCounter) |
It's probably better to paint the bits when they are in the on state too, it's more consistent.
But I added different alpha values, to make it easier to see when the bit changes by clicking with the mouse.
I have tried several values and these seem to go well with dark and light themes.
Oh, i tried to land the code but the automatic checker complained about your full name being "athurh". Do you have a surname?
Looks like I can't change the username in phabricator's settings.
If some admin can, my complete name is "athurh eof" ;-)
You've sadly triggered my "this is probably a fake name" detector.
At this point we're not sure if we should accept contributions with non real/identifiable names.
See the discussion at https://mail.kde.org/pipermail/kde-community/2019q2/thread.html
Sadly, I prefer to stay anonymous.
I don't care if my name appears in the commit, so you can push the changes as your own.
Can you explain what are your reasons to want to stay anonymous? Or you feel you'd lose anonymity already by doing so?
Meanwhile, i think it's fair to accept your contribution if you propose a commit to the kde-dev-scripts with this patch
diff --git a/relicensecheck.pl b/relicensecheck.pl index e9265bf..0aac179 100755 --- a/relicensecheck.pl +++ b/relicensecheck.pl @@ -32,6 +32,7 @@ use List::Util qw(any); my %license_table = ( 'acrouthamel' => ['gplv23', 'lgplv23', 'gplv2+', 'lgplv2+', '+eV', 'CCBYSA4' ], 'aheinecke' => ['gplv23', 'lgplv23', 'gplv2+', 'lgplv2+', '+eV', 'CCBYSA4' ], + 'athurhfree' => ['gplv23', 'lgplv23', 'gplv2+', 'lgplv2+', '+eV', 'CCBYSA4' ], 'cgerloff' => ['gplv23', 'lgplv23', 'gplv2+', 'lgplv2+', '+eV', 'CCBYSA4' ], 'flherne' => ['gplv23', 'lgplv23', 'gplv2+', 'lgplv2+', '+eV', 'CCBYSA4' ], 'huoni' => ['gplv23', 'lgplv23', 'gplv2+', 'lgplv2+', '+eV', 'CCBYSA4' ], @@ -409,6 +410,7 @@ my %secondary_mail_addresses = ( 'thb@net-bembel.de' => 'tbaumgart', 'trev@adblockplus.org' => 'palant', 'tsdgeos@terra.es' => 'aacid', + 'athurh@gmail.com' => 'athurhfree', ); my %ruletable;
This way we won't have problems if ever we want to relicense the code.
There's no particular reason, just privacy.
I could create an account with a random name and everything would be fine.
Since there is no way to verify the names, I don't know why a Random Name is somehow better than a randomnick.
Anyway I have send the patch to kde-dev-scripts.