Previously we were only having the wallpaper plugins' child form layouts hooked up to the main form layouts. That causes issues when a label in a plugin is longer than the labels in the main layout. To solve the issue, this patch also makes the main layout responsive to the content of the child layouts.
Details
Details
- Reviewers
ngraham mart - Group Reviewers
Plasma - Commits
- R119:1c6644a42b7a: Hook up the main form layout with child form layouts
Before:
After:
Diff Detail
Diff Detail
- Repository
- R119 Plasma Desktop
- Branch
- hook-main-and-child-layouts-up (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 10528 Build 10546: arc lint + arc unit
Comment Actions
twinFormLayouts: main.currentItem will stop working as soon as the wallpaper plugin in anything more complicated than having a single form layout. How do I specify that, yes, I want the currentItem, but only the form layout in that file?
Comment Actions
Figured it out. We'll just export a formLayout alias property in all the individual plugins and everything will work.
Comment Actions
@mart before you suggested we should do something like:
twinFormLayouts: stack.item && stack.item.formLayout ? [stack.item.formLayout] : []
but I'm not seeing any errors or issues if twinFormLayouts doesn't find main.currentItem.formLayout.
Is the diff okay then or should I specify that it shouldn't do anything if it doesn't find a child form layout?
Comment Actions
I'll land this tomorrow night (in 24hrs) since it's a prerequisite for fixing the PoTD plugin.