The bug was that the Drawer use the drawerOpen properties now instead of just open. And fix deprecation Kirigami.Label -> QQC2.Label.
Details
Details
- Reviewers
ngraham - Group Reviewers
Okular - Commits
- R223:2d568acd7d5f: Update some files to QQC2 and fix minor bug
Tested on my computer with the touchpad. I could potentialy try with my android phone, if needed.
Diff Detail
Diff Detail
- Repository
- R223 Okular
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 7759 Build 7777: arc lint + arc unit
mobile/app/package/contents/ui/Thumbnails.qml | ||
---|---|---|
21 | This will bump the Qt dependency to 5.12, which is not necessary for any changes in this patch. | |
mobile/app/package/contents/ui/ThumbnailsBase.qml | ||
21 |
| |
mobile/app/package/contents/ui/TreeDelegate.qml | ||
21 | Ditto | |
mobile/components/DocumentView.qml | ||
21 ↗ | (On Diff #50630) | Ditto |
31 ↗ | (On Diff #50630) | Ditto |
mobile/app/package/contents/ui/ThumbnailsBase.qml | ||
---|---|---|
21 | I meant, this can go up 2.0, just not 2.5. |
Comment Actions
So I tried to test ScrollView on my computer with a small display, on it look like it's working. But I prefer to revert this change, and reapply the change concerning ScrollView latter, after testing with my android phone with multitouch support.