Create bedDeform object Similar to Temperature Data
Details
Diff Detail
- Repository
- R232 AtCore
- Branch
- getBedDeform
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 7508 Build 7526: arc lint + arc unit
src/core/atcore.cpp | ||
---|---|---|
110–112 | Just to make sure, this will be removed before the merge right ? | |
src/core/beddeform.cpp | ||
36 | Please add examples of what this regex will get. | |
src/core/beddeform.h | ||
41 | Can you document this functions ? | |
43 | What is data in BedDeform ? What is the unit ? Should this be a QVector3D ? |
src/core/atcore.cpp | ||
---|---|---|
110–112 | Yes. |
src/core/atcore.h | ||
---|---|---|
542 | If this is wrong we should also fix the Temperature object return. (it returns a constRef to the temperature object) |
src/core/atcore.h | ||
---|---|---|
542 | QObjects are not allowing copies. So only by ref is working. I'm also having various issues storing via QSharedPtr and various smart pointers. (maybe i am doing it wrong?) |
src/core/CMakeLists.txt | ||
---|---|---|
44 | Please, add in alphabetic order. | |
src/core/beddeform.h | ||
43 | @rizzitello ping ^ |
src/core/beddeform.h | ||
---|---|---|
43 | The data is a list of floats. These floats are how off the Z you are at each probe point, For example my machine has 9 points so i get a list of 9 floats that will be something like 0.25, 0.3 , 0 , 0.01 , .03 .... etc each value is just how high or low the probe is compared to where home was triggered. There is no point data as the grind stops are not returned with the command just that list of N floats, one for each probe point. |
src/core/beddeform.h | ||
---|---|---|
43 | This Z points doe not provide any useful information without X,Y point information.
Ok, I understand that this is 4 points in Z, but where ? In the corner of the table ? in a 1cm centralized square in the center ? points around the edge of the 3D object that will be printed ? |
src/core/beddeform.h | ||
---|---|---|
43 | I don't know where they will be on your bed. This points are at the locations set when building the firmware, The user can set as many and places each in any spot. I do not know how to get the point locations from the FW. |
src/core/beddeform.h | ||
---|---|---|
43 | I think we should store it as a QVector for now, this will not change existent code, will make it more frigidly to the qml, and also more future proof if the 3D Printer or the profile could provide such point information. |