Create Bed Deform Object
Needs ReviewPublic

Authored by rizzitello on Jan 23 2019, 3:06 PM.

Details

Summary

Create bedDeform object Similar to Temperature Data

Diff Detail

Repository
R232 AtCore
Branch
getBedDeform
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 8165
Build 8183: arc lint + arc unit
rizzitello requested review of this revision.Jan 23 2019, 3:06 PM
rizzitello created this revision.
rizzitello updated this revision to Diff 50113.Jan 23 2019, 3:08 PM
  • update base
rizzitello retitled this revision from Track the lastCommand set to the printer to Create Bed Deform Object.
rizzitello edited the summary of this revision. (Show Details)
rizzitello added a project: Atelier: AtCore.
rizzitello added a subscriber: Atelier: AtCore.
tcanabrava requested changes to this revision.Jan 25 2019, 9:04 AM
tcanabrava added inline comments.
src/core/atcore.cpp
116–118

if this is just for debugging purposes, remove?

src/core/atcore.h
583

return by copy, this eliminates possible crashes.

src/core/beddeform.h
44

const ref

This revision now requires changes to proceed.Jan 25 2019, 9:04 AM
rizzitello updated this revision to Diff 50246.Jan 25 2019, 1:00 PM
rizzitello edited the summary of this revision. (Show Details)
  • Missing Const Ref (Thanks Tomaz !)
rizzitello marked an inline comment as done.Jan 25 2019, 1:00 PM
rizzitello added inline comments.
src/core/atcore.cpp
116–118

Yes, Its for testing / debugging since there Is currently no other way to check that data was read correctly.

src/core/beddeform.h
44

Wouln't be a review if I didn't forget one const Ref :P

patrickelectric requested changes to this revision.Jan 26 2019, 2:21 PM
patrickelectric added inline comments.
src/core/atcore.cpp
116–118

Just to make sure, this will be removed before the merge right ?

src/core/beddeform.cpp
37

Please add examples of what this regex will get.

src/core/beddeform.h
42

Can you document this functions ?

44

What is data in BedDeform ? What is the unit ? Should this be a QVector3D ?

This revision now requires changes to proceed.Jan 26 2019, 2:21 PM
rizzitello updated this revision to Diff 50332.Jan 26 2019, 4:48 PM
rizzitello marked 4 inline comments as done.
rizzitello edited the summary of this revision. (Show Details)
  • documents update
rizzitello marked 2 inline comments as done.Jan 26 2019, 4:49 PM
rizzitello added inline comments.
src/core/atcore.cpp
116–118

Yes.

rizzitello added inline comments.Jan 26 2019, 4:51 PM
src/core/atcore.h
583

If this is wrong we should also fix the Temperature object return. (it returns a constRef to the temperature object)

src/core/beddeform.cpp
37

So, this is the same of -* ?

43

This number can be in any place ?
Can you put some examples like inputs -> outputs

rizzitello updated this revision to Diff 50405.Jan 28 2019, 2:25 AM
  • Better examples
rizzitello updated this revision to Diff 50406.Jan 28 2019, 2:41 AM
rizzitello marked 2 inline comments as done.
  • Better explain regex
rizzitello updated this revision to Diff 50407.Jan 28 2019, 3:33 AM
  • Use QVariantList and set Q_Property for QML export
rizzitello updated this revision to Diff 50408.Jan 28 2019, 4:03 AM
  • Add tests
rizzitello updated this revision to Diff 50428.Jan 28 2019, 2:04 PM
  • remove extra include
rizzitello marked 2 inline comments as done.Jan 28 2019, 2:06 PM
rizzitello added inline comments.
src/core/atcore.h
583

QObjects are not allowing copies. So only by ref is working. I'm also having various issues storing via QSharedPtr and various smart pointers. (maybe i am doing it wrong?)

src/core/atcore.h
583

You can define a copy operator.

src/core/beddeform.cpp
45

Can you put also the generated output ?
You should use the named regex to get the output.

rizzitello updated this revision to Diff 50432.Jan 28 2019, 2:58 PM
rizzitello marked 2 inline comments as done.
  • use std::shared_ptr for bed Deform , more examples , capture by name in the regex
rizzitello marked an inline comment as done.Jan 28 2019, 2:58 PM
rizzitello updated this revision to Diff 50441.Jan 28 2019, 4:25 PM
  • Remove added new line and un needed include
tcanabrava accepted this revision.Jan 30 2019, 8:05 AM

I still don't like the shared ptr but let's go with that for now.