We need to return the absolute path instead of base name so decoColorToCombo
can return the correct index.
Details
Details
- Reviewers
davidedmundson - Group Reviewers
KWin - Commits
- R108:de04d362da3b: [kcmkwin/rules] Return absolute path of decoration color scheme
- Go to System Settings > Window Management > Window Rules;
- Create a new rule for Konsole to force the Oxygen color scheme, close the dialog, and click the Apply button;
- Open the rules dialog (you don't have to modify anything), click OK button, then Apply button.
Without this patch, Breeze color scheme will be forced after the
last step.
Diff Detail
Diff Detail
- Repository
- R108 KWin
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Could that be a fallout from the fact that color scheme names are now translated? I get mapping failures all over the place now (Kate, Krita, …) because Honigwabe isn't Honeycomb.
Comment Actions
Wait, filenames are translated as well?
Not the filename, the Name in the .colors file, it's a desktop file and as such can also do Name[de]
Also, why are they translated anyway?
To provide a better user experience, not everyone is familiar with the English language.
Comment Actions
This definately used to work in the past. I rather think it's a fallout from switching to dbus.
Comment Actions
I think the problem lies in the fact that Rules are "persistent". Initially, decocolor will be an absolute path. After the second step in the test plan, decocolor will be a basename, so in the third step when setRules is called, decoColorToCombo won't be able to return the correct index(basename != absolute path).