Add runner for geo uris
ClosedPublic
Actions

Authored by kossebau on Jul 4 2016, 6:39 AM.

Details

Reviewers

nienhueser
rahn

Group Reviewers

Marble

Commits

R34:7dc16625aa76: Add runner for geo uris

Summary

Supports only geo uris with CRS mathcing the current globe

Repository

R34 Marble

Branch

addGeoUriRunner

Lint

No Linters Available

Unit

No Unit Test Coverage

kossebau retitled this revision from to Add runner for geo uris.

kossebau updated this object.

src/plugins/runner/geouri/GeoUriPlugin.h
28	We should use that (the override keyword) at more places, me thinks.
src/plugins/runner/geouri/GeoUriRunner.cpp
62	What is the idea here? Use the altitude for zooming? The zoomLevel property is not used for that IIRC.

src/plugins/runner/geouri/GeoUriRunner.cpp
62	Yes, seems that is clueless code :) Inspired from FileLoaderPrivate::createFilterProperties and what it does for // Mountain (H), Volcano (V), Shipwreck (W). But right, now looking at the API dox of GeoDataFeature::setZoomLevel() this is complete bogus, and I just should set it to 1, so the search result is always shown.

Removed bogus zoomlevel setting

Looks good.

This revision is now accepted and ready to land.Jul 9 2016, 3:25 PM

This revision was automatically updated to reflect the committed changes.

		Path
M		src/plugins/runner/CMakeLists.txt (1 line)
A	M	src/plugins/runner/geouri/CMakeLists.txt (10 lines)
A	M	src/plugins/runner/geouri/GeoUriPlugin.h (47 lines)
A	M	src/plugins/runner/geouri/GeoUriPlugin.cpp (68 lines)
A	M	src/plugins/runner/geouri/GeoUriRunner.h (32 lines)
A	M	src/plugins/runner/geouri/GeoUriRunner.cpp (70 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	4922	7b68c80		Jul 4 2016, 6:39 AM	★	★
Diff 2	4957	d69a3c0	Removed bogus zoomlevel setting	Jul 5 2016, 10:50 AM	★	★
Diff 3	5044	35ee150	rMARBLE7dc16625aa76aacf518d39f8acc12e7c6bac4f2e	Jul 9 2016, 4:39 PM	★	★