- Improve warning message with line number
BUG: 386151
dhaumann |
KTextEditor |
BUG: 386151
Lint Skipped |
Unit Tests Skipped |
Well, if it is fixed I can't say. At least the error is gone and "Increment/Decrement" works.
May some guru investigate if its fixed. Obviously is there a problem with these string constants.
@carewolf This issue was caused by the QtScript to QML migration in KTextEditor. Could you have a look or pass this on the relevant V4 developers to investigate whether this is possibly a bug in V4?
Btw, I committed this, but now the length of the string is 14 characters instead of 8, so this patch is certainly wrong. But better this than a completely broken emmet.
src/script/data/libraries/emmet/lib.js | ||
---|---|---|
5434 | Is that even valid JS? Shouldn\t it be \xHH with hexidecimal? |
src/script/data/libraries/emmet/lib.js | ||
---|---|---|
5434 | Being a js-noob, I did some searchin the net and it seems to me that \211 is supposed to be octal sequence. On https://stackoverflow.com/questions/21071921 it is said that octal sequences are optional in the standard... But indeed I assume this should work. |
src/script/data/libraries/emmet/lib.js | ||
---|---|---|
5434 | https://mathiasbynens.be/notes/javascript-escapes might also be interesting for more background. Maybe the octal notation was deprecated as well... So best would be to fix emmet upstream. |
May I ask a stupid question? Is the entire function needed? That's looks to me somehow like image/picture stuff but I don't find picture stuff in the Tool->Emmet menu.